public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][RM3679] Query Tool not working
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][RM3679] Query Tool not working
@ 2019-01-03 07:36 Aditya Toshniwal <[email protected]>
  2019-01-03 14:44 ` Re: [pgAdmin4][RM3679] Query Tool not working Dave Page <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Toshniwal @ 2019-01-03 07:36 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

This is related to a very difficult to reproduce issue where query tool
opens blank. Note the disconnected icon, not to be confused with another
issue where resizing the query tool works and icon is connected.
Somehow, this occurred on my system (screenshot attached). It turned out to
be a webpack issue and many users are facing this (in other projects).
A workaround suggested by
https://github.com/webpack/webpack/issues/6094#issuecomment-413178158 is
applied in the attached patch.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


Attachments:

  [image/png] Screenshot 2019-01-03 at 12.17.45 PM.png (477.7K, 3-Screenshot%202019-01-03%20at%2012.17.45%20PM.png)
  download | view image

  [application/octet-stream] RM3679.patch (715B, 4-RM3679.patch)
  download | inline diff:
diff --git a/web/webpack.config.js b/web/webpack.config.js
index 2e214fc7..10ae9969 100644
--- a/web/webpack.config.js
+++ b/web/webpack.config.js
@@ -19,7 +19,10 @@ const webpackShimConfig = require('./webpack.shim');
 const PRODUCTION = process.env.NODE_ENV === 'production';
 const OptimizeCssAssetsPlugin = require('optimize-css-assets-webpack-plugin');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
-const extractStyle = new ExtractTextPlugin('[name].css');
+const extractStyle = new ExtractTextPlugin({
+  filename: '[name].css',
+  allChunks: true,
+});
 const envType = PRODUCTION ? 'production': 'development';
 const HardSourceWebpackPlugin = require('hard-source-webpack-plugin');
 


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][RM3679] Query Tool not working
  2019-01-03 07:36 [pgAdmin4][RM3679] Query Tool not working Aditya Toshniwal <[email protected]>
@ 2019-01-03 14:44 ` Dave Page <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2019-01-03 14:44 UTC (permalink / raw)
  To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Thu, Jan 3, 2019 at 7:37 AM Aditya Toshniwal
<[email protected]> wrote:
>
> Hi Hackers,
>
> This is related to a very difficult to reproduce issue where query tool opens blank. Note the disconnected icon, not to be confused with another issue where resizing the query tool works and icon is connected.
> Somehow, this occurred on my system (screenshot attached). It turned out to be a webpack issue and many users are facing this (in other projects).
> A workaround suggested by https://github.com/webpack/webpack/issues/6094#issuecomment-413178158 is applied in the attached patch.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2019-01-03 14:44 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-03 07:36 [pgAdmin4][RM3679] Query Tool not working Aditya Toshniwal <[email protected]>
2019-01-03 14:44 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox