public inbox for [email protected]help / color / mirror / Atom feed
pgAdmin4 form control error icon position change 4+ messages / 3 participants [nested] [flat]
* pgAdmin4 form control error icon position change @ 2018-03-21 08:58 Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2018-03-21 08:58 UTC (permalink / raw) To: pgadmin-hackers *Hi Team,* This is regarding the position of error icon of a pgAdmin form control. Below are the screenshots. As we can see, the error icon is overlapping the control buttons like the drop down button, spinner up down buttons, etc. We propose that we can move the error icon to the front of the label of the form control. Below are screenshots. Attached is the patch for the above changes. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions Pune | Mob - 8055837949 Attachments: [image/png] image.png (11.6K, 3-image.png) download | view image [text/x-patch] pgadmin_ctrlerroricon.patch (1.4K, 4-pgadmin_ctrlerroricon.patch) download | inline diff: diff --git a/web/pgadmin/static/css/bootstrap.overrides.css b/web/pgadmin/static/css/bootstrap.overrides.css index d2936a7..2ab44f0 100755 --- a/web/pgadmin/static/css/bootstrap.overrides.css +++ b/web/pgadmin/static/css/bootstrap.overrides.css @@ -269,7 +269,7 @@ iframe { .control-label { margin: 0px; - padding: 5px; + padding: 5px 25px 5px 5px; display: inline-block; vertical-align: middle; } diff --git a/web/pgadmin/static/css/pgadmin.css b/web/pgadmin/static/css/pgadmin.css index 6c1002c..666140e 100644 --- a/web/pgadmin/static/css/pgadmin.css +++ b/web/pgadmin/static/css/pgadmin.css @@ -732,7 +732,7 @@ lgg-el-container[el=md] .pg-el-lg-8, padding-top: 6px; padding-bottom: 6px; padding-left: 5px; - padding-right: 5px; + padding-right: 25px; display: inline-block; vertical-align: middle; min-height: 28px; diff --git a/web/pgadmin/static/scss/_backform.overrides.scss b/web/pgadmin/static/scss/_backform.overrides.scss index 2aa9460..b22c55a 100644 --- a/web/pgadmin/static/scss/_backform.overrides.scss +++ b/web/pgadmin/static/scss/_backform.overrides.scss @@ -8,14 +8,14 @@ color: #d0021b; } - .pgadmin-controls:before { + .control-label:before { font: normal normal normal 16px/1 FontAwesome; content: "\f071"; text-decoration: inherit; position: absolute; color: #d0021b; - right: 15px; - padding-top: 10px; + right: 6px; + padding-top: 6px; z-index: 1; } } ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin4 form control error icon position change @ 2018-03-21 09:21 Murtuza Zabuawala <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Murtuza Zabuawala @ 2018-03-21 09:21 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Hello Aditya, Could you please create new RM <https://redmine.postgresql.org/projects/pgadmin4; for the issue, so that we can keep track of changes, It will be difficult for us to keep track of email for the details. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 21, 2018 at 2:28 PM, Aditya Toshniwal < [email protected]> wrote: > > *Hi Team,* > > This is regarding the position of error icon of a pgAdmin form control. > Below are the screenshots. As we can see, the error icon is overlapping the > control buttons like the drop down button, spinner up down buttons, etc. > > > > > We propose that we can move the error icon to the front of the label of > the form control. Below are screenshots. > > > > > Attached is the patch for the above changes. > Kindly review. > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions > Pune | Mob - 8055837949 > Attachments: [image/png] image.png (11.6K, 3-image.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin4 form control error icon position change @ 2018-03-21 09:34 Aditya Toshniwal <[email protected]> parent: Murtuza Zabuawala <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2018-03-21 09:34 UTC (permalink / raw) To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers Created - https://redmine.postgresql.org/issues/3226 On Wed, Mar 21, 2018 at 2:51 PM, Murtuza Zabuawala < [email protected]> wrote: > Hello Aditya, > > Could you please create new RM > <https://redmine.postgresql.org/projects/pgadmin4; for the issue, so that > we can keep track of changes, It will be difficult for us to keep track > of email for the details. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Wed, Mar 21, 2018 at 2:28 PM, Aditya Toshniwal <aditya.toshniwal@ > enterprisedb.com> wrote: > >> >> *Hi Team,* >> >> This is regarding the position of error icon of a pgAdmin form control. >> Below are the screenshots. As we can see, the error icon is overlapping the >> control buttons like the drop down button, spinner up down buttons, etc. >> >> >> >> >> We propose that we can move the error icon to the front of the label of >> the form control. Below are screenshots. >> >> >> >> >> Attached is the patch for the above changes. >> Kindly review. >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions >> Pune | Mob - 8055837949 >> > > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions Pune | Mob - 8055837949 Attachments: [image/png] image.png (11.6K, 3-image.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin4 form control error icon position change @ 2018-03-23 09:57 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Dave Page @ 2018-03-23 09:57 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Murtuza Zabuawala <[email protected]>; pgadmin-hackers Thanks Aditya, patch applied. On Wed, Mar 21, 2018 at 9:34 AM, Aditya Toshniwal < [email protected]> wrote: > Created - https://redmine.postgresql.org/issues/3226 > > > On Wed, Mar 21, 2018 at 2:51 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hello Aditya, >> >> Could you please create new RM >> <https://redmine.postgresql.org/projects/pgadmin4; for the issue, so >> that we can keep track of changes, It will be difficult for us to keep >> track of email for the details. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Wed, Mar 21, 2018 at 2:28 PM, Aditya Toshniwal < >> [email protected]> wrote: >> >>> >>> *Hi Team,* >>> >>> This is regarding the position of error icon of a pgAdmin form control. >>> Below are the screenshots. As we can see, the error icon is overlapping the >>> control buttons like the drop down button, spinner up down buttons, etc. >>> >>> >>> >>> >>> We propose that we can move the error icon to the front of the label of >>> the form control. Below are screenshots. >>> >>> >>> >>> >>> Attached is the patch for the above changes. >>> Kindly review. >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions >>> Pune | Mob - 8055837949 <(805)%20583-7949> >>> >> >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions > Pune | Mob - 8055837949 <(805)%20583-7949> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company Attachments: [image/png] image.png (11.6K, 3-image.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2018-03-23 09:57 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2018-03-21 08:58 pgAdmin4 form control error icon position change Aditya Toshniwal <[email protected]> 2018-03-21 09:21 ` Murtuza Zabuawala <[email protected]> 2018-03-21 09:34 ` Aditya Toshniwal <[email protected]> 2018-03-23 09:57 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox