public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button
Date: Wed, 5 Jun 2019 12:18:03 +0100
Message-ID: <CA+OCxowteeh7yjQLToCGWPtFsqSKK10E3wX6o8k8i5Rub-DoGA@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mhLAoL3ZgY3w8SCH6WbSF=_11tU3Ueh-voAWkfgVZtVw@mail.gmail.com>
References: <CAM9w-_mhLAoL3ZgY3w8SCH6WbSF=_11tU3Ueh-voAWkfgVZtVw@mail.gmail.com>
Hi
On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the patch to fix an issue where using browser autofills in
> alertify dialogs triggers the help page button (#4317).
> A workaround was added to master password dialog to avoid this, but that
> in turn disabled the 'OK' button tigger on pressing enter button. This is
> also fixed with this patch.(#4310)
>
This isn't quite right. When the browser auto-fills the password, the OK
button remains disabled. I can hit enter though - however, I shouldn't be
able to do that when the OK button is disabled (being the default button on
the dialogue, it should respond to enter, unless another control which also
accepts enter has focus (e.g. a multiline text area).
The OK button should be enabled - probably all the time, as the user could
have entered a blank password, and most systems won't prevent a user from
trying to use such a password.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button
In-Reply-To: <CA+OCxowteeh7yjQLToCGWPtFsqSKK10E3wX6o8k8i5Rub-DoGA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox