public inbox for [email protected]  

help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button
Date: Mon, 10 Jun 2019 14:04:10 +0100
Message-ID: <CA+OCxozSR5G2qEp5Mj7h0eJVP48Yqy9qQ7RiYLxXwbJ2AAO7kA@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mStAKAox2OeezDYXP2953mFdkQYJK6c+3y7CmpUkPyyg@mail.gmail.com>
References: <CAM9w-_mhLAoL3ZgY3w8SCH6WbSF=_11tU3Ueh-voAWkfgVZtVw@mail.gmail.com>
	<CA+OCxowteeh7yjQLToCGWPtFsqSKK10E3wX6o8k8i5Rub-DoGA@mail.gmail.com>
	<CAM9w-_mn7mBrAcpBqMayPPU-btXenfX5+YKmsp_8w5qFd0903w@mail.gmail.com>
	<CA+OCxozgD-eUgFDKwkMjuUEt3v25PsEDpMX+Kkp2qKsSctzs2A@mail.gmail.com>
	<CAM9w-_mStAKAox2OeezDYXP2953mFdkQYJK6c+3y7CmpUkPyyg@mail.gmail.com>

Thanks, applied!

On Mon, Jun 10, 2019 at 10:35 AM Aditya Toshniwal <
[email protected]> wrote:

> Hi,
>
> On Mon, Jun 10, 2019 at 2:34 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Wed, Jun 5, 2019 at 1:39 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> On Wed, Jun 5, 2019 at 4:48 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is the patch to fix an issue where using browser autofills in
>>>>> alertify dialogs triggers the help page button (#4317).
>>>>> A workaround was added to master password dialog to avoid this, but
>>>>> that in turn disabled the 'OK' button tigger on pressing enter button. This
>>>>> is also fixed with this patch.(#4310)
>>>>>
>>>>
>>>> This isn't quite right. When the browser auto-fills the password, the
>>>> OK button remains disabled. I can hit enter though - however, I shouldn't
>>>> be able to do that when the OK button is disabled (being the default button
>>>> on the dialogue, it should respond to enter, unless another control which
>>>> also accepts enter has focus (e.g. a multiline text area).
>>>>
>>> The autofilled password appears as set, but it is actually not set to
>>> textbox unless you enter/click in the dropdown. We get the DOM element
>>> value as blank even if it appears filled. This is how chromium autofill
>>> behaves. Upon hitting enter the autofill value is set to the textbox and OK
>>> button is enabled.
>>>
>>>>
>>>> The OK button should be enabled - probably all the time, as the user
>>>> could have entered a blank password, and most systems won't prevent a user
>>>> from trying to use such a password.
>>>>
>>> I have made the changes to allow blank master password, plus enabling OK
>>> button always. Attached is the updated patch.
>>>
>>
>> I think you've slightly mis-understood what I was trying to say.
>>
>> - We should not allow a blank password.
>> - We should not disable the OK button at all.
>>
>> My analogy was focussed on the fact that most systems never disable OK
>> buttons on login dialogues, as some of those systems (but not all of
>> course) may allow blank passwords.
>>
> Got it !! Attached is the updated patch.
>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (6+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button
  In-Reply-To: <CA+OCxozSR5G2qEp5Mj7h0eJVP48Yqy9qQ7RiYLxXwbJ2AAO7kA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox