public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing
Date: Wed, 15 Feb 2017 15:27:14 +0000
Message-ID: <CA+OCxowzkV6SLbxSzxfFw4spD8_EZjSWdXaDLMWrEGpch=G=0w@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELckCk=XnadYMwZ5hifg2qLQ5Q5AWbuLOgG3LRax_K-DrQ@mail.gmail.com>
References: <CAFOhELdtSDCcHTs+LJukGH5E_xUYfm0JJLwpKrq+SfLqcWthKg@mail.gmail.com>
	<CANxoLDeAD3VPenh7BCxtBWyZfcOD3LhA1bbOqc5xZ3foFxkshg@mail.gmail.com>
	<CA+OCxowrguJS2U8hDSg88VJdirRkdVg4OCMWESypMbeJmXz_DA@mail.gmail.com>
	<CAFOhELdfheYVqBeW_7M1_gnS-cw=HhYd7sJffc6F8ittP0moog@mail.gmail.com>
	<CA+OCxow=60KmJjxW2ORn4SaJacdpqEXn5f+-5-a1_BAXwudcHw@mail.gmail.com>
	<CAFOhELckCk=XnadYMwZ5hifg2qLQ5Q5AWbuLOgG3LRax_K-DrQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

On Fri, Feb 10, 2017 at 7:28 AM, Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, Feb 3, 2017 at 7:53 PM, Dave Page <[email protected]>
> wrote:
>
>>
>>
>> On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi <
>> [email protected]> wrote:
>>
>>>
>>>
>>> On Fri, Feb 3, 2017 at 7:02 PM, Dave Page <[email protected]>
>>> wrote:
>>>
>>>> I doubt the order matters, but feel free to change it if it bugs you :-)
>>>>
>>>>
>>> I have tried to create the function with both SQL commands.
>>> There is no bug, its just in pgAdmin4, if its not leakproof then we
>>> mentioned 'NOT LEAKPROOF'  in the SQL.
>>> So, I am not sure, we should remove it or not.
>>>
>>
>> Well we should be consistent - we either list the full set of all
>> options, or just the non-default ones. The main thing is that we don't
>> explicitly show options that are the default in some cases, but not in
>> others.
>>
>>
> Agreed.  Fixed for LEAKPROOF and PARALLEL options.
>

This seems to work in edit mode, but not in create mode, where the PARALLEL
option that's selected is simply ignored in the msql.

-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing
  In-Reply-To: <CA+OCxowzkV6SLbxSzxfFw4spD8_EZjSWdXaDLMWrEGpch=G=0w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox