public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Ganesh Jaybhay <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
Date: Tue, 9 Jul 2019 16:58:41 +0100
Message-ID: <CA+OCxoxHi6PU7dTbC1qvswniaCsrGmhkfaRYO_jimX14xg3zhQ@mail.gmail.com> (raw)
In-Reply-To: <CAK6syAryyMuRZVBe=dz47kWk0fr2Yy2-j53Tj8LGJCx3gpbQhA@mail.gmail.com>
References: <CAK6syAryyMuRZVBe=dz47kWk0fr2Yy2-j53Tj8LGJCx3gpbQhA@mail.gmail.com>

Hi,

What's the ticket number for this? That's a fair amount of code for a
one-line description. There are also no doc changes describing how to
navigate the sub-node control that I can see.

Also; instead of changing the repo used for backgrid, can we not
un-vendorise it?

On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is the patch for keyboard accessibility of sub-node control. It
> also covers sub-node dialog forward/backward tab navigation with shortcuts.
>
> Kindly review.
>
> Regards,
> Ganesh Jaybhay
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
  In-Reply-To: <CA+OCxoxHi6PU7dTbC1qvswniaCsrGmhkfaRYO_jimX14xg3zhQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox