public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Ganesh Jaybhay <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
Date: Fri, 12 Jul 2019 10:06:57 +0100
Message-ID: <CA+OCxoxQB16hT+C7qnR+OOLuihDDqXXE89LooAAawqGHDKORkg@mail.gmail.com> (raw)
In-Reply-To: <CAK6syArpb7-W16pMzOKaEHzjNtRW8ZeqzcL4aB_eH14kCR1Www@mail.gmail.com>
References: <CAK6syAryyMuRZVBe=dz47kWk0fr2Yy2-j53Tj8LGJCx3gpbQhA@mail.gmail.com>
<CA+OCxoxHi6PU7dTbC1qvswniaCsrGmhkfaRYO_jimX14xg3zhQ@mail.gmail.com>
<CAK6syAqgLAVLsWCoevtnWX+V_cgKOQra=oohXwnrzYj7fSp9ug@mail.gmail.com>
<CA+OCxoxnzFjL0DrQNs=ps1QtxtuLVEgnB74jfPQX-i5aH3i7Lw@mail.gmail.com>
<CA+OCxoyqq5q9vPK7zmWf-g3=F4hL9gf0nUeW0g6oOawgs05P-w@mail.gmail.com>
<CAK6syArpb7-W16pMzOKaEHzjNtRW8ZeqzcL4aB_eH14kCR1Www@mail.gmail.com>
Thanks - committed as the IE fixes, with the Jasmine stuff as a bonus :-)
On Thu, Jul 11, 2019 at 7:40 PM Ganesh Jaybhay <
[email protected]> wrote:
> Hi Dave,
>
> Please find the attached patch for jasmine tests fix. Patch also includes
> fixes for edit/delete cell focus on IE by Murtuza.
>
> Regards,
>
> Ganesh Jaybhay
>
> On Thu, Jul 11, 2019 at 3:49 PM Dave Page <[email protected]> wrote:
>
>> Hi Ganesh,
>>
>> It looks like this has broken the Jasmine tests (which I admit I forgot
>> to run before committing). Can you fix ASAP please?
>>
>> Thanks.
>>
>> On Thu, Jul 11, 2019 at 10:14 AM Dave Page <[email protected]> wrote:
>>
>>> Thanks - patch applied with some doc tweaks.
>>>
>>> No need for a new ticket!
>>>
>>> On Thu, Jul 11, 2019 at 7:00 AM Ganesh Jaybhay <
>>> [email protected]> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Ticket number 3919 refers to keyboard accessibility issues for sub-node
>>>> control and back grid but this patch covers only sub-node control. Should I
>>>> create new one?
>>>> I have added the screenshot having newly added shortcut and updated
>>>> keyboard shortcut rst file. Also moved the code changes from backgrid.js to
>>>> backgrid.pgadmin.js.
>>>>
>>>> Please find the attached updated patch.
>>>>
>>>> Regards,
>>>> Ganesh Jaybhay
>>>>
>>>> On Tue, Jul 9, 2019 at 9:28 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> What's the ticket number for this? That's a fair amount of code for a
>>>>> one-line description. There are also no doc changes describing how to
>>>>> navigate the sub-node control that I can see.
>>>>>
>>>>> Also; instead of changing the repo used for backgrid, can we not
>>>>> un-vendorise it?
>>>>>
>>>>> On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached is the patch for keyboard accessibility of sub-node control.
>>>>>> It also covers sub-node dialog forward/backward tab navigation with
>>>>>> shortcuts.
>>>>>>
>>>>>> Kindly review.
>>>>>>
>>>>>> Regards,
>>>>>> Ganesh Jaybhay
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (7+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
In-Reply-To: <CA+OCxoxQB16hT+C7qnR+OOLuihDDqXXE89LooAAawqGHDKORkg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox