public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Victoria Henry <[email protected]>
Cc: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Anthony Emengo <[email protected]>
Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests
Date: Wed, 13 Jun 2018 09:56:00 +0100
Message-ID: <CA+OCxoxbOX5RFHp6=nt0prwOitLcBSsAYb8=kgQSZgTnbpYFeA@mail.gmail.com> (raw)
In-Reply-To: <CANxYE3+8Y75o5cfG78+G4y1gKDPbCTzoKteQfKGcVV5jJ-vNcA@mail.gmail.com>
References: <CAG8BBZM0gapFd0ZvMq7euCYamxKEBNqewC4YX4bYddyc_6AatA@mail.gmail.com>
<CA+OCxoyhMprhxCMss5oESTMcVVnVcyBOP_AuntNyZsRyeZu5rg@mail.gmail.com>
<CAG8BBZOkQ8FPzXzJAwe5+EgAKEhbpcx+_=XQh3UQhWQE620xqg@mail.gmail.com>
<CA+OCxozBpu020t4+tagcvMStjHakp7aEduGVOFgM8quaRvmxCg@mail.gmail.com>
<CAE+jjam92a4rwYM+VxekLTRjLoWdAiPw4MuiCP1dUT_aWc5-6g@mail.gmail.com>
<CA+OCxowt6nQrdNj-tKupZ_ohJeGyH20G3VfNVjKa85RgVe+A1g@mail.gmail.com>
<CAE+jjakFfSjDWyyQEwQrAsveSSWvJ_cpcNESeC6F4TShZqfP8Q@mail.gmail.com>
<CAE+jjakW15xMbHyMBUu6X_7ndi07ymrwyE4cV_=txSSXBcSNuA@mail.gmail.com>
<CA+OCxowq+5CSjtQNnmy_vf4m3=kd6XGYyFkh=nevQ6qF+5RxPg@mail.gmail.com>
<CAE+jjanMmCJzHbMgtxB-6D8+Dvp9bbqEkiSE=oDuVxUU=AOzrA@mail.gmail.com>
<CA+OCxoyJKFcoBkAb65ZgTsb-V9wbuz5nFfGM26nmiRAcTND-kw@mail.gmail.com>
<CANxYE3+8Y75o5cfG78+G4y1gKDPbCTzoKteQfKGcVV5jJ-vNcA@mail.gmail.com>
Hi
On Tue, Jun 12, 2018 at 8:39 PM, Victoria Henry <[email protected]> wrote:
> Hi Dave,
>
>
>>
>> No, because it's firewalled to the nines inside our network. There's no
>> chance I'm making production build machines internet-accessible.
>>
>
> For a Open Source project, if the community cannot see the place where the
> tests are running it looses a huge part of the process. We believe that
> removing this capability will have a negative impact on the development,
> especially because we do not have a CI/CD. Before the code is merged we
> will never know if master is broken or not.
>
This is one of multiple CI/CD systems; specifically it's the one that will
be producing our official builds. Security always trumps developer
convenience for build machines as far as I'm concerned - have you ever had
to deal with a possibly-compromised build server and the PR fallout etc
that can result from that?
The existing public system will be replaced with one that mirrors a portion
of the build system; specifically, the test jobs, but not the production
build jobs or dependencies. It may be removed completely in the future if I
can find a way to securely allow access to build info from the build system.
>
>
>>
>>
>>> We have some examples from our pipeline that we can share:
>>> Script that we use to run the UT + Feature tests on a docker image that
>>> has python+yarn+selenium+postgres installed on it:
>>> https://github.com/greenplum-db/pgadmin4-ci/blob/master/
>>> tasks/run-postgres-tests/run.sh
>>>
>>> This type of scripts can be added to the Jenkinsfile to create a
>>> pipeline step. A good practice in a reproducible pipeline is to use Docker
>>> to ensure that every test runs in a clean and predictable environment, this
>>> make it easy to reproduce a problem found in testing.
>>>
>>
>> Docker is of little use to us here, as 2 of the 4 build platforms cannot
>> be run in Docker (macOS and the Docker container), and the 3rd would be
>> extremely difficult to run that way (Windows)
>>
>
> The docker files that we are talking about here is to run the tests, and
> we believe that the tests are all running in a Linux environment.
>
No, I'm running tests on all platforms. We've proven numerous times that
just running them on Linux is not enough.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests
In-Reply-To: <CA+OCxoxbOX5RFHp6=nt0prwOitLcBSsAYb8=kgQSZgTnbpYFeA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox