public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: Victoria Henry <[email protected]>
Cc: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Anthony Emengo <[email protected]>
Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests
Date: Mon, 18 Jun 2018 11:13:30 +0530
Message-ID: <CAFOhELfp-YYctKk5BW228msAh2RmJcxE=QQR7PmhYhrHsr-GPw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxerf5iC3YiF2urmguyaXVc=_q2kPiwbg+ZrfBYOrAduQ@mail.gmail.com>
References: <CAG8BBZM0gapFd0ZvMq7euCYamxKEBNqewC4YX4bYddyc_6AatA@mail.gmail.com>
	<CA+OCxoyhMprhxCMss5oESTMcVVnVcyBOP_AuntNyZsRyeZu5rg@mail.gmail.com>
	<CAG8BBZOkQ8FPzXzJAwe5+EgAKEhbpcx+_=XQh3UQhWQE620xqg@mail.gmail.com>
	<CA+OCxozBpu020t4+tagcvMStjHakp7aEduGVOFgM8quaRvmxCg@mail.gmail.com>
	<CAE+jjam92a4rwYM+VxekLTRjLoWdAiPw4MuiCP1dUT_aWc5-6g@mail.gmail.com>
	<CA+OCxowt6nQrdNj-tKupZ_ohJeGyH20G3VfNVjKa85RgVe+A1g@mail.gmail.com>
	<CAE+jjakFfSjDWyyQEwQrAsveSSWvJ_cpcNESeC6F4TShZqfP8Q@mail.gmail.com>
	<CAE+jjakW15xMbHyMBUu6X_7ndi07ymrwyE4cV_=txSSXBcSNuA@mail.gmail.com>
	<CA+OCxowq+5CSjtQNnmy_vf4m3=kd6XGYyFkh=nevQ6qF+5RxPg@mail.gmail.com>
	<CAE+jjanMmCJzHbMgtxB-6D8+Dvp9bbqEkiSE=oDuVxUU=AOzrA@mail.gmail.com>
	<CA+OCxoy6=pT+Fe2qh11aPzZ-psBC1mTu=Rj-dqdUaV2tXy4NwA@mail.gmail.com>
	<CANxYE3KnRLfGxVgj2+ePbjhgwmoLPXzk0XLskUj0cTABLo25Pg@mail.gmail.com>
	<CA+OCxoxerf5iC3YiF2urmguyaXVc=_q2kPiwbg+ZrfBYOrAduQ@mail.gmail.com>

Hi,

The supported versions of
Pytest: Python 2.7, Python 3.4+, PyPy 2.3, Jython 2.5 (untested);
Grappa: Python 2.7+, 3+

References:
https://docs.pytest.org/en/latest/
https://github.com/grappa-py/grappa

So, how are we going to handle unsupported versions (PY 2.6 and 3.3) ?

Thanks,
Khushboo

On Wed, Jun 13, 2018 at 6:07 PM, Dave Page <[email protected]> wrote:

> Hi
>
> On Tue, Jun 12, 2018 at 3:41 PM, Victoria Henry <[email protected]> wrote:
>
>> Hi Dave,
>>
>> Attached are four different patches that should be applied in order.
>> Included is a fix for the failing test above.
>>
>
> This is no longer failing :-)
>
> However, I'm still seeing problems that need to be resolved:
>
> - Passwords are still being written to the log file. This is a complete
> show-stopper.
>
> - The regression.log file is empty. I'm now only getting the JSON summary.
> We really need both - the regression log for diagnostics, and the JSON file
> for feeding into monitoring systems.
>
> - There is still no summary list of tests that failed or were skipped
> output at the end of the run. This is important because it highlights which
> tests failed (obviously!) and need investigation, and knowing which ones
> are skipped at a glance is very useful as they can be skipped due to
> mis-configuration; e.g. running against a different server than intended,
> or failing to specify something like a tablespace path which we can then
> easily see to fix.
>
> - I cannot run against servers other than the first one in the config
> file. We need to run against all that are enabled, and have the output show
> which one was used for each one as we have now. This may seem trivial, but
> it's really not - to the point that for some of us it negates the whole
> point of the patch by giving us more control over which tests are run but
> removing all control over which database servers they will run against. In
> my case, this will almost certainly cost even more time; right now I just
> have to run more tests than I may need but I can do other things at the
> same time. With this patch I'll have to keep re-running the tests,
> modifying the config between each run.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (17+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests
  In-Reply-To: <CAFOhELfp-YYctKk5BW228msAh2RmJcxE=QQR7PmhYhrHsr-GPw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox