public inbox for [email protected]  

help / color / mirror / Atom feed

From: Joao De Almeida Pereira <[email protected]>
To: Dave Page <[email protected]>
Cc: Anthony Emengo <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests
Date: Thu, 24 May 2018 15:36:37 -0400
Message-ID: <CAE+jjam92a4rwYM+VxekLTRjLoWdAiPw4MuiCP1dUT_aWc5-6g@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozBpu020t4+tagcvMStjHakp7aEduGVOFgM8quaRvmxCg@mail.gmail.com>
References: <CAG8BBZM0gapFd0ZvMq7euCYamxKEBNqewC4YX4bYddyc_6AatA@mail.gmail.com>
	<CA+OCxoyhMprhxCMss5oESTMcVVnVcyBOP_AuntNyZsRyeZu5rg@mail.gmail.com>
	<CAG8BBZOkQ8FPzXzJAwe5+EgAKEhbpcx+_=XQh3UQhWQE620xqg@mail.gmail.com>
	<CA+OCxozBpu020t4+tagcvMStjHakp7aEduGVOFgM8quaRvmxCg@mail.gmail.com>

As part of the development environment we do not see the reasoning behind
not add PYTHONPATH to the environment variables, specially because this
looks like the way pytest was invisoned.

However please try the following patch instead. We've changed the pytest
invocation to assume the relevant dir as part of the directories to load,
as well as the docs and Makefile

Thanks
Joao && Anthony

On Thu, May 24, 2018 at 12:24 PM Dave Page <[email protected]> wrote:

>
>
> On Thu, May 24, 2018 at 5:14 PM, Anthony Emengo <[email protected]>
> wrote:
>
>> Here’s a followup patch with the relevant README and Makefile changes. To
>> be clear, both patches need to be applied in succession to run the tests.
>>
>> The error that you were running into was because the appropriate
>> PYTHONPATH environment variable was not set. We updated the README to
>> reflect that, but haven’t done anything to the code for that
>>
> That really needs to be fixed then. I shouldn't need to do anything beyond
> activate the appropriate virtual environment (which I had done).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


Attachments:

  [application/octet-stream] 0002-Use-Pytests-v2.git-diff (3.1K, 3-0002-Use-Pytests-v2.git-diff)
  download

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests
  In-Reply-To: <CAE+jjam92a4rwYM+VxekLTRjLoWdAiPw4MuiCP1dUT_aWc5-6g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox