public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Patch: Added select2cell editor for backgrid [pgAdmin4]
Date: Tue, 5 Apr 2016 16:51:06 +0100
Message-ID: <CA+OCxoxuP_KwJpAnXao7xNcJ1MKJ834jVMt_F1DVQ-iSND==pQ@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmowT9NKtspfFxd6ZkPoXK=_cCkqEczPPvisoLNirg=iyQw@mail.gmail.com>
References: <CAKKotZQRdDZmkkd2QA37PoHxFXQV+aPZuTste4-w6SDACfXk3Q@mail.gmail.com>
<CAG7mmow0LAPVzyHFo-osO-=-sz_n01Bcc=19=XcxZYRfnogHEQ@mail.gmail.com>
<CAKKotZTesaNnLC7B3XAE=T7aqNrp_a3hFzMM3gneRsFand5Q6g@mail.gmail.com>
<CAG7mmowT9NKtspfFxd6ZkPoXK=_cCkqEczPPvisoLNirg=iyQw@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
I've reverted the change to overrides.css that this patch made as it was
that that was causing the padding issue on backgrid that we noted this
morning when looking at the debugger.
+}
+
+.select2-cell .select2-container > .backgrid th, .backgrid td
+{
+ padding: 0px;
Please fix in a less blanket way.
On Mon, Apr 4, 2016 at 11:07 AM, Ashesh Vashi <[email protected]
> wrote:
> Thanks - committed with small changes.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com;
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi;
>
> On Mon, Apr 4, 2016 at 1:09 PM, Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA updated patch.
>>
>> Regards,
>> Murtuza
>>
>>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Apr 1, 2016 at 3:08 PM, Ashesh Vashi <
>> [email protected]> wrote:
>>
>>> On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> We have added Select2Cell Editor for backgrid, eariler as it was not
>>>> present & causing issue in rendering in subnode control.
>>>>
>>> Looks good to me, but - have some feedback.
>>> 1. Can you please mention - why do we need 'openOnEnter: false' in
>>> select2 options?
>>> 2. There is a difference between UI, when rendered from the editor, and
>>> from the Select2Cell. (I can see padding, when the Cell is rendered, but -
>>> not when editor is rendered.)
>>>
>>> Can you please fix this two?
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com/;
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi;
>>>
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list ([email protected])
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>
>>>>
>>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Patch: Added select2cell editor for backgrid [pgAdmin4]
In-Reply-To: <CA+OCxoxuP_KwJpAnXao7xNcJ1MKJ834jVMt_F1DVQ-iSND==pQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox