public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ashesh Vashi <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Patch: Added select2cell editor for backgrid [pgAdmin4]
Date: Mon, 4 Apr 2016 15:37:09 +0530
Message-ID: <CAG7mmowT9NKtspfFxd6ZkPoXK=_cCkqEczPPvisoLNirg=iyQw@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZTesaNnLC7B3XAE=T7aqNrp_a3hFzMM3gneRsFand5Q6g@mail.gmail.com>
References: <CAKKotZQRdDZmkkd2QA37PoHxFXQV+aPZuTste4-w6SDACfXk3Q@mail.gmail.com>
	<CAG7mmow0LAPVzyHFo-osO-=-sz_n01Bcc=19=XcxZYRfnogHEQ@mail.gmail.com>
	<CAKKotZTesaNnLC7B3XAE=T7aqNrp_a3hFzMM3gneRsFand5Q6g@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks - committed with small changes.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;

On Mon, Apr 4, 2016 at 1:09 PM, Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> PFA updated patch.
>
> Regards,
> Murtuza
>
>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Apr 1, 2016 at 3:08 PM, Ashesh Vashi <
> [email protected]> wrote:
>
>> On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> We have added Select2Cell Editor for backgrid, eariler as it was not
>>> present & causing issue in rendering in subnode control.
>>>
>> Looks good to me, but - have some feedback.
>> 1. Can you please mention - why do we need 'openOnEnter: false' in
>> select2 options?
>> 2. There is a difference between UI, when rendered from the editor, and
>> from the Select2Cell. (I can see padding, when the Cell is rendered, but -
>> not when editor is rendered.)
>>
>> Can you please fix this two?
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi;
>>
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list ([email protected])
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Patch: Added select2cell editor for backgrid [pgAdmin4]
  In-Reply-To: <CAG7mmowT9NKtspfFxd6ZkPoXK=_cCkqEczPPvisoLNirg=iyQw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox