public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: Fixed typo in Server node
Date: Fri, 6 May 2016 13:58:54 +0100
Message-ID: <CA+OCxoxxer8WrntwcctX_s7hQhqLTA6SSa_4TM7H7bx0zN3P3w@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZRLW_+g-qqGA9RVN5dbM7FAJi651KtYKA=QA+j3R7H9og@mail.gmail.com>
References: <CAKKotZRLW_+g-qqGA9RVN5dbM7FAJi651KtYKA=QA+j3R7H9og@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks - applied.
On Fri, May 6, 2016 at 11:14 AM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi,
>
> Looks like below given commit has left a typo in the code, I’m getting error
> while updating any Server node,
>
> Commit:
> 0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page
> 2016-05-05 16:42:16 +0100 377)
> node=self.blueprint.generate_browser_node(
>
> Error:
> return method(*args, **kwargs)
> File
> "/Users/murtuza/Desktop/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
> line 385, in update
> server_type='pg' # default server type
> TypeError: make_json_response() got an unexpected keyword argument ‘node'
>
>
>
> PFA patch to fix the issue.
>
>
>
> Regards,
> Murtuza
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: Fixed typo in Server node
In-Reply-To: <CA+OCxoxxer8WrntwcctX_s7hQhqLTA6SSa_4TM7H7bx0zN3P3w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox