public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: PATCH: Fixed typo in Server node
Date: Fri, 6 May 2016 15:44:12 +0530
Message-ID: <CAKKotZRLW_+g-qqGA9RVN5dbM7FAJi651KtYKA=QA+j3R7H9og@mail.gmail.com> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi,
Looks like below given commit has left a typo in the code, I’m getting
error while updating any Server node,
*Commit:*
0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page
2016-05-05 16:42:16 +0100 377)
node=self.blueprint.generate_browser_node(
*Error:*
* return method(*args, **kwargs)*
* File
"/Users/murtuza/Desktop/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
line 385, in update*
* server_type='pg' # default server type*
*TypeError: make_json_response() got an unexpected keyword argument ‘node'*
PFA patch to fix the issue.
Regards,
Murtuza
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] fixed_typo.patch (659B, 3-fixed_typo.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py
index ac1d32f..3bc0717 100644
--- a/web/pgadmin/browser/server_groups/servers/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/__init__.py
@@ -374,7 +374,7 @@ class ServerNode(PGChildNodeView):
return make_json_response(
success=1,
- node=self.blueprint.generate_browser_node(
+ data=self.blueprint.generate_browser_node(
"%d" % (server.id), server.servergroup_id,
server.name,
"icon-server-not-connected" if not connected else
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: PATCH: Fixed typo in Server node
In-Reply-To: <CAKKotZRLW_+g-qqGA9RVN5dbM7FAJi651KtYKA=QA+j3R7H9og@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox