public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Regarding non-ascii characters in the path for Windows installer
Date: Mon, 20 Jan 2025 09:04:01 +0000
Message-ID: <CA+OCxoy+rc9h1w6C5SizrObECn3R0YGLb9-O=az44osHnzCt=g@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfbrus5yOZN6UXuGSpFCcrSekrJOHieH7Dh0us7GSQC2g@mail.gmail.com>
References: <CANxoLDdq6E8uMHMqcMw_Qz4EFV_Fx4m_4fvwkmnU=YkFxEdqDg@mail.gmail.com>
<CA+OCxox7H9hLn9CjKJQErqKXU+cbedaxW7aq1KLJfoRqUYO+-A@mail.gmail.com>
<CANxoLDfbrus5yOZN6UXuGSpFCcrSekrJOHieH7Dh0us7GSQC2g@mail.gmail.com>
On Mon, 20 Jan 2025 at 08:26, Akshay Joshi <[email protected]>
wrote:
>
>
> On Fri, Jan 17, 2025 at 5:32 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, 16 Jan 2025 at 11:23, Akshay Joshi <[email protected]>
>> wrote:
>>
>>> Hi Dave/Hackers
>>>
>>> I am looking into issue 5204
>>> <https://github.com/pgadmin-org/pgadmin4/issues/5204; where the pgAdmin
>>> 4 Windows installer throws an error of "Please provide a valid path," when
>>> the user name contains non-ASCII characters.
>>>
>>> We have added a function IsPathValid to validate the path in the "
>>> installer.iss.in" file, because of this function Windows installer
>>> throws an error.
>>>
>>> [image: Code.png]
>>> Can we remove this logic? Thoughts/Suggestions?
>>>
>>
>> I don't think we can just remove it - if memory serves, we added it
>> because we ran into issues in some cases. Obviously we can't do an
>> exhaustive test, but can we confirm that pgAdmin will work with at
>> least some non-ASCII characters in the path, e.g. some accented characters,
>> Kanji, Cyrillic etc?
>>
>
> We added this function in 2017 to address issue #1365
> <https://redmine.postgresql.org/issues/1365;. The issue reported that
> pgAdmin would not launch after installation. At that time, we were using QT
> (Mingw), which is no longer used.
> For testing purposes, I removed the function call from the
> installer.iss.in file and conducted tests using the following username:
>
> [image: Screenshot 2025-01-20 at
> 1.30.44 PM.png]
>
> The user names mentioned above include accented characters, Kanji, and
> Cyrillic scripts. pgAdmin 4 was installed and ran successfully without any
> issues.
> Let's remove that function. Thoughts/Suggestions?
>
Seems reasonable to me, given the original motivation and your testing.
Thank you!
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com
Attachments:
[image/png] Code.png (121.9K, 3-Code.png)
download | view image
[image/png] Screenshot 2025-01-20 at 1.30.44 PM.png (451.7K, 4-Screenshot%202025-01-20%20at%201.30.44%E2%80%AFPM.png)
download | view image
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Regarding non-ascii characters in the path for Windows installer
In-Reply-To: <CA+OCxoy+rc9h1w6C5SizrObECn3R0YGLb9-O=az44osHnzCt=g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox