public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Date: Wed, 16 Jan 2019 14:59:47 +0000
Message-ID: <CA+OCxoyQxmbFzFrxYLadJsM3QDK0G1qmiCZ7aGx1wodw8QHndQ@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfyrMSyscZODjuvHE11CzaUA8XdAJd45jR7aQgmwtNhPg@mail.gmail.com>
References: <[email protected]>
<CA+OCxoyp8XjOa0xdiqoohiQ1Bm0fcrruXTWu-Y_mqY5LaGeBoQ@mail.gmail.com>
<CAM9w-_ngsgJxJOJKngc-3W8tqNymKeZjBCuW2_VN-nb4k5du=g@mail.gmail.com>
<CA+OCxoxHWJK+XA6zROKWznJkJf1=adDEoafqCoz9BPnMvmtzAg@mail.gmail.com>
<CA+OCxoyuDXfZR2zNKONy-CWWYbo_xAeLZRVZwVZ=1_gU+4zUAg@mail.gmail.com>
<CAM9w-_mXaptQzE45a3eRfLB5qG0R+qUm6JnAnR4C6rOZ8fiJFw@mail.gmail.com>
<CA+OCxowym3tJZfDkOJkqfsNbaxT=Z=nnxCEQWF4nm+HL5q8_qQ@mail.gmail.com>
<CAM9w-_nXoXLjm4jyJKsZ1vOXJLei7akyrBQMOY+p_jmDzmEmdg@mail.gmail.com>
<CA+OCxow69BHrCT7JcdfVyFwn0JnWEszaMdwxuWaxBddKf=h4mg@mail.gmail.com>
<CAM9w-_myZ=B-Nzt9DGAnvXVQgz3szAbe13cLPC4kSSXbUQXt6w@mail.gmail.com>
<CAM9w-_=sK8X=VXE8mqVY6+McuM=EXwg8_xJ56tf_0pHDvvH7uQ@mail.gmail.com>
<CAM9w-_nkvOB5VTGwLkhDiNUYGF1yho0H6BniUoKFM8vveb3zKg@mail.gmail.com>
<CANxoLDeLe0YKm4hZOpwFX79p+DuR0ocibYkH8WFLtk6XwLNK2w@mail.gmail.com>
<CAM9w-_niKinU7MWXxth4Em9BQc=xDKOwgbApL58viZq2zJ=phw@mail.gmail.com>
<CA+OCxow9Kw-KAL366JBPxZ1p4cRDuMe=DWv7v5AygAcm8v19hQ@mail.gmail.com>
<CAM9w-_k95kK6PHtcgh-eQwH_h6HYV64gbLqdS3Lp7zwWDrw0hA@mail.gmail.com>
<CA+OCxoyBjf2bV+ybc6Cj8759K_FzL+585LKgCo8kersTK+eeHQ@mail.gmail.com>
<CAM9w-_=8Fz0Ly4KuvzED-ayjgqDvVwTsfWuQpFB8YQvcF-TgTQ@mail.gmail.com>
<CA+OCxoz419cvzChkxULcK4MvvaE+D=u5GEVjV1u3SYGF9g5+LA@mail.gmail.com>
<CAM9w-_=+ONV6MNjDPStk6KsQoYqKQ3OW1U_1Wk7396qDMGgN=g@mail.gmail.com>
<CA+OCxoxAut_n6_zaoTP=CWHwiZzj0Z+sXAciNZeEQs3fhcO9cg@mail.gmail.com>
<CAM9w-_nBHxUooWSeCABxMGP_i4GKbi1S6MdZgTht0FxwpuDfnw@mail.gmail.com>
<CAM9w-_=GUJ5XtCjKj9KHn8Q3oz=Y91y7v7Bp0kf2iRCK2eqYbw@mail.gmail.com>
<CANxoLDfyrMSyscZODjuvHE11CzaUA8XdAJd45jR7aQgmwtNhPg@mail.gmail.com>
On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi <[email protected]>
wrote:
> Thanks patch applied without Tree Changes.
>
> On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal <aditya.toshniwal@
> enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for further design improvements:
>> - Process watcher made fixed width with header changes, time details
>> rounded to 2 decimals
>> - Query history will show "No query history" if no query fired. Query
>> editor default size increased.
>> - Tree improvements - right bold border removed completely. Now click
>> anywhere on a tree item to perform actions. Please note, single click on
>> the tiny tree arrow button will not work with this. Clicking anywhere is
>> more useful than this.
>>
> @Dave Should we proceed with this behaviour, I haven't commit it.
>
I like the blue bit, so that should come back.
I would say that a single-click on the arrow should open/close the node,
whilst a double-click on the icon or label should open/close it.
> - Fixed a bug where New folder create button not working when in List mode
>> and No files/folder present.
>> - Other minor improvements.
>>
>> Kindly review.
>>
>> On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch for few more changes:
>>> - New Folder button was not working in file dialogue. Fixed that.
>>> - Color, icon changes in file dialogue
>>> - Also replaced the splash screen image (which is used on main dashboard
>>> also). It works fine on dashboard. However, I'm not sure of the splash
>>> screen as the new image is SVG and older was PNG. I have made changes for
>>> that in runtime code but I'm not able to test (evnvironment issue) runtime
>>> code :(. It would be helpful if someone else can try it once.
>>>
>>> Kindly review.
>>>
>>>
>>> On Mon, Jan 7, 2019 at 2:25 PM Dave Page <[email protected]> wrote:
>>>
>>>> Thanks - applied!
>>>>
>>>> On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal
>>>> <[email protected]> wrote:
>>>> >
>>>> > Hi Hackers,
>>>> >
>>>> > Attached is the patch to incorporate the changes discussed in
>>>> trailing mail(s).
>>>> >
>>>> > Kindly review.
>>>> >
>>>> > On Fri, Jan 4, 2019 at 3:31 PM Dave Page <[email protected]> wrote:
>>>> >>
>>>> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal
>>>> >> <[email protected]> wrote:
>>>> >> >
>>>> >> > Hi,
>>>> >> >
>>>> >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page <[email protected]>
>>>> wrote:
>>>> >> >>
>>>> >> >> Hi
>>>> >> >>
>>>> >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>> >> >>>
>>>> >> >>> Hi Dave,
>>>> >> >>>
>>>> >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page <[email protected]>
>>>> wrote:
>>>> >> >>>>
>>>> >> >>>>
>>>> >> >>>> A few other things that I noticed (or have been bugging me):
>>>> >> >>>>
>>>> >> >>>> - The menu bar seems a little cramped. Taking pg-navbar from 32
>>>> to 40px and setting the font-weight to normal on the menu options (but not
>>>> the product name) seems much better to me (and adjusting everything else as
>>>> required of course).
>>>> >> >>>
>>>> >> >>> Giving too much space for the navbar will reduce the usable
>>>> space for other things. It is good enough(32) to be used easily, and is
>>>> equal to all the other headers in app (including tabs) giving a feel of
>>>> native desktop application. You'll find even smaller menu heights in native
>>>> desktop application. We can make font weight to normal and may be slightly
>>>> increase horizontal spacing between the menu links.
>>>> >> >>
>>>> >> >>
>>>> >> >> 8 pixels isn't going to make a noticeable difference to the
>>>> workspace for users, and would leave the bar smaller than the 50px it's
>>>> been for the last couple of years (iirc). I think it needs it to avoid
>>>> looking cramped - please make the change.
>>>> >> >
>>>> >> > Will do.
>>>> >> > One more doubt regarding bold headers, should I remove bold
>>>> headers in dashboard graph header, subnode headers (eg.table->columns),
>>>> properties tab accrordian headers ?
>>>> >>
>>>> >> No, please don't. I left them bold and the styling seemed like it
>>>> >> worked. We can tweak again if others disagree later.
>>>> >>
>>>> >> Thanks!
>>>> >>
>>>> >> BTW - Chrome 71 shows the offset headers in the file dialogue as
>>>> well.
>>>> >>
>>>> >> >>>>
>>>> >> >>>> - In the file dialogue, the column headers don't line up with
>>>> the columns in the rows.
>>>> >> >>>
>>>> >> >>> I could not see this on my machine (screenshot attached). Could
>>>> you please share the screenshot.
>>>> >> >>
>>>> >> >>
>>>> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS.
>>>> >> >>
>>>> >> >> --
>>>> >> >> Dave Page
>>>> >> >> Blog: http://pgsnake.blogspot.com
>>>> >> >> Twitter: @pgsnake
>>>> >> >>
>>>> >> >> EnterpriseDB UK: http://www.enterprisedb.com
>>>> >> >> The Enterprise PostgreSQL Company
>>>> >> >
>>>> >> >
>>>> >> >
>>>> >> > --
>>>> >> > Thanks and Regards,
>>>> >> > Aditya Toshniwal
>>>> >> > Software Engineer | EnterpriseDB Software Solutions | Pune
>>>> >> > "Don't Complain about Heat, Plant a tree"
>>>> >>
>>>> >>
>>>> >>
>>>> >> --
>>>> >> Dave Page
>>>> >> Blog: http://pgsnake.blogspot.com
>>>> >> Twitter: @pgsnake
>>>> >>
>>>> >> EnterpriseDB UK: http://www.enterprisedb.com
>>>> >> The Enterprise PostgreSQL Company
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> > Thanks and Regards,
>>>> > Aditya Toshniwal
>>>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>>>> > "Don't Complain about Heat, Plant a tree"
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
view thread (29+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
In-Reply-To: <CA+OCxoyQxmbFzFrxYLadJsM3QDK0G1qmiCZ7aGx1wodw8QHndQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox