public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: Neel Patel <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] [Patch]: Extension Module
Date: Wed, 24 Feb 2016 16:47:12 +0000
Message-ID: <CA+OCxoyeCxRWgBa=Yq_h6uAkgv9oXWfRkK-r9JiAaFSVnSOmpg@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D8cMiiUsSYt8sE+-+hhLPm0F+2ughxvohuqUMi1f_Xs0A@mail.gmail.com>
References: <CAM5-9D9k1MGYxhf-pobDbeDJxOttVawje=JzFesEMgD=fxRR+w@mail.gmail.com>
<CAM5-9D9P6tfPajz1mUi1B03+ypLKsebehkaxWfV_C6k=ZjCSPg@mail.gmail.com>
<CACCA4P3JuzVzoq7DFmyFzjbKaE3uf-P1+4_zkBO6RfxTB-VVSQ@mail.gmail.com>
<CAM5-9D_jZUQMinr4s3upX3ktSM6AV_NWQ-RMQMjyroWMNL3bcg@mail.gmail.com>
<CAM5-9D81Yg5ofY0bjgZvSDM7Gt1t7bTuqgMSmExx1086tMT7Qg@mail.gmail.com>
<CAM5-9D-c2s9bfxVgoZMHbWNsvsiQzyHSMtx2revHz-2vaDYTJw@mail.gmail.com>
<CACCA4P2OFF8mHsRocYpq+YFV5mMZTw1yLOW-FYsHuOvrm7G0UQ@mail.gmail.com>
<CAM5-9D-FMDcV8L1FbPiEU4pCeOO1dcLu-62r5CHRuO_ks9hiSw@mail.gmail.com>
<CACCA4P27KHmsiWAJzOy3rL+9pLyg1jr=c27kbK97g+N3nAZZyQ@mail.gmail.com>
<CAM5-9D9LD+e0U2O59qdHc8zSKmazT0OytybFOQnNKLsr5SxkrA@mail.gmail.com>
<CA+OCxowvwaqPNzn317d4CEa3HC2j8RfFNPH2SNNuJ+QpaAt=0A@mail.gmail.com>
<CAM5-9D8cMiiUsSYt8sE+-+hhLPm0F+2ughxvohuqUMi1f_Xs0A@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks - committed.
On Tue, Feb 23, 2016 at 11:07 AM, Surinder Kumar <
[email protected]> wrote:
> Hi,
>
> PFA patch with changes suggested by Dave
>
> Please review the patch and let me know for any comments.
>
> On Mon, Feb 15, 2016 at 4:37 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Mon, Feb 15, 2016 at 9:55 AM, Surinder Kumar <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA patch with following changes:
>>>
>>> 1. Added "Create Extension" menu item in context menu of Database
>>> node.
>>> 2. Added a new method "node_node" in ExtensionModule class. If a
>>> node has child, returns True, otherwise False.
>>> 3. Fixed an issue in which icon won't display in create extension
>>> link in context menu.
>>> 4. Added Docstring for the class and methods in python file and
>>> proper commenting in js file.
>>> 5. Followed PEP-08 coding conventions.
>>>
>>>
>> I haven't tested this, but a few initial comments:
>>
>> - The commenting of the JS code is better than I've seen in other patches
>> \o/, but the commenting style is inconsistent. We should use /* */ for
>> multi-line comments, and // for single line.
>> - The JS code could use some carefully introduced blank lines to help
>> make it more readable.
>>
> Done
>
>> - s/}else{/} else {/
>>
> Done
>
>> - Dependency/depends display is missing (see previous email to Akshay).
>> This is essential for this node!
>>
> Implemented dependency and depends
>
>> - There's no pydoc comment introducing __init__.py
>>
> Added pydoc
>
>> - Shouldn't "data='-- Modified SQL --'," be "data=gettext('-- Modified
>> SQL --'),"?
>>
> Yes, it should be. Fixed.
>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (13+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4] [Patch]: Extension Module
In-Reply-To: <CA+OCxoyeCxRWgBa=Yq_h6uAkgv9oXWfRkK-r9JiAaFSVnSOmpg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox