public inbox for [email protected]  

help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] [Patch]: Extension Module
Date: Mon, 18 Jan 2016 16:52:50 +0530
Message-ID: <CACCA4P3JuzVzoq7DFmyFzjbKaE3uf-P1+4_zkBO6RfxTB-VVSQ@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D9P6tfPajz1mUi1B03+ypLKsebehkaxWfV_C6k=ZjCSPg@mail.gmail.com>
References: <CAM5-9D9k1MGYxhf-pobDbeDJxOttVawje=JzFesEMgD=fxRR+w@mail.gmail.com>
	<CAM5-9D9P6tfPajz1mUi1B03+ypLKsebehkaxWfV_C6k=ZjCSPg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Surinder,

We have applied/tested the patch and below are the review comments.

1. When we select the extension "plpython3u", "plperl", "plperu" etc. then
it gives 'TypeError' in Javascript.
TypeError: d.version is undefined
'version': (!_.isNull(d.version[0]) ? d.version[0]: '')

We are getting this error while selecting many extensions so please test
with all types of extensions, it should not give any error at client side.

2.  Use 2 space indentation instead of 4 space in javascript file.

3. In "validate" function in "extension.js" file, validate only the changed
values not all, and "this.get('name') - should be called only one time not
multiple
    time".

4. When we pass object identifier, use the function 'qtIdent', and for the
values, use function  'qtLiteral' in all the sql files.

5. By default, when we create the extension, "schema_name" and "version"
should not be be set with value. It should be set blank by default.

6. When we create any extension like "citext" then we are not able to
create the same extension again after deleting the same extension. May be
issue
    with caching mechanism.

7. When we remove the schema_name during the "Edit" operation then wrong
SQL is getting generated.

8. Remove "Use Slony" option. As discussed with Ashesh, we will implement
it as separate module.


Please fix the above issues. Let us know if you want more information.

Thanks,
Neel Patel


Thanks,
Neel Patel


On Tue, Jan 12, 2016 at 1:15 PM, Surinder Kumar <
[email protected]> wrote:

> Please find the updated patch with following changes:
>
>    1. corrected copyright.
>    2. Added proper comment for script_module function in __init__.py file.
>    3. Renamed collection Node's label to Extensions in extensions.js file.
>
>
> On Tue, Jan 12, 2016 at 12:44 PM, Surinder Kumar <
> [email protected]> wrote:
>
>> Hi,
>>
>> Please find attached patch for the extension module.
>> Please review it and Let me know for any comments.
>>
>>
>> Thanks,
>> Surinder Kumar
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4] [Patch]: Extension Module
  In-Reply-To: <CACCA4P3JuzVzoq7DFmyFzjbKaE3uf-P1+4_zkBO6RfxTB-VVSQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox