public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3161] Fix PEP-8 issues
Date: Fri, 2 Mar 2018 11:59:27 +0000
Message-ID: <CA+OCxoyppYKJNvZw1Kie4uym8ippNA6yvpEwagkLmhn-d4K75A@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZT00X-s2LmazsZ3AMOGN9hUnOBrWx4jGX09xcGVcd2n2g@mail.gmail.com>
References: <CAKKotZQMOj_zqgGmyYYjxUTiXG6P-CvV3broqRDhV8TUaNPY5Q@mail.gmail.com>
<CAE+jja=uTE4MVvPU8A2-BCbi2Wkt1LCAmN910DZ3f+ug2Ep6nQ@mail.gmail.com>
<CAKKotZT00X-s2LmazsZ3AMOGN9hUnOBrWx4jGX09xcGVcd2n2g@mail.gmail.com>
Thanks, applied.
On Thu, Mar 1, 2018 at 5:13 AM, Murtuza Zabuawala <
[email protected]> wrote:
> Thank you Joao for reviewing.
>
> On Thu, Mar 1, 2018 at 3:10 AM, Joao De Almeida Pereira <
> [email protected]> wrote:
>
>> Hello Murtuza,
>>
>> I passed the patch through our CI and all test are green. Also run the
>> codestyle in all those folders and everything is clean.
>>
>> 575 issues to go
>>
>> Thanks
>> Joao
>>
>> On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions
>>> and Languages module.
>>>
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/languages/
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/extensions/
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/event_triggers/
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/casts/
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][RM#3161] Fix PEP-8 issues
In-Reply-To: <CA+OCxoyppYKJNvZw1Kie4uym8ippNA6yvpEwagkLmhn-d4K75A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox