public inbox for [email protected]  

help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Feature #5370 User should be able to set the binary path for each database server
Date: Fri, 21 May 2021 10:16:32 +0100
Message-ID: <CA+OCxoz-28ghNLD3wq6XpwnY+uLf4Ve0OsL2o46TrE-w5PEjZw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDc37ss+TA4o_yBahGUO+WWm9U7ZEZ-js9Pyb0ZWcKXpLw@mail.gmail.com>
References: <CANxoLDfRrBE4e0sFL7nt7GxRy4ALyjCMSwv_YC1RPq33uWBzwA@mail.gmail.com>
	<CAM9w-_nYDWxCVOB6-xLu-Yqw79juoAKv1Jv7UJcSujphPK2hkg@mail.gmail.com>
	<CANxoLDfe8H-E9qmO1KYiRVodpBRWPcEmxKKKwPXQ4MDShE9XPQ@mail.gmail.com>
	<CA+OCxozFY0Vs_KmhmCR0ranY=ti-Qc5YU1vM1nPsj0erQDnWvQ@mail.gmail.com>
	<CANxoLDeeYbPuZc4DPdsCMEEiPdwopM+cq0VOwsrahz1wvjZQNg@mail.gmail.com>
	<CA+OCxozkNdeH3RmMm-wS_YLNScRn7fUqZ0zEf+p9MVeWR_u+tQ@mail.gmail.com>
	<CANxoLDf82r-kZfctPF5kG1dePwgCEveL=XGo7anmZi9Vvjdb=Q@mail.gmail.com>
	<CA+OCxozV34Ec_+VoxNfUL0ROdsuzmyqvo_wfosBUSw6OTssUGg@mail.gmail.com>
	<CANxoLDc37ss+TA4o_yBahGUO+WWm9U7ZEZ-js9Pyb0ZWcKXpLw@mail.gmail.com>

Hi Akshay,

On Fri, May 21, 2021 at 10:01 AM Akshay Joshi <[email protected]>
wrote:

>
>
> On Fri, May 21, 2021 at 1:01 PM Dave Page <[email protected]> wrote:
>
>> Hi Akshay,
>>
>> On Fri, May 21, 2021 at 8:03 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Dave/Hackers
>>>
>>>     As per your suggestion, I have created a new Backform control
>>> "BinaryPathsGridControl" and two new BackgridCell (BackgridRadioCell and
>>> BackgridSelectFileCell). Please refer to the screenshot below:
>>>                                      [image: Binary_Path.png]
>>>
>>>    Are the above changes look good to you? The radio button will only be
>>> enabled when there is a path. Added validate button which will validate the
>>> Utilities (pg_dump, pg_dumpall, ...)
>>>
>>
>> Nice! Just a couple of comments:
>>
>> - I assume the browse button is removed in server mode as discussed?
>> Maybe we should add a config.py option to allow that behaviour to be
>> overridden if the admin doesn't care about sandboxing?
>>
>
>      Yes, will take care that in server mode browse button should not be
> visible. if the config option "ENABLE_FILE_BROWSING" is set to true then
> only the browse button will be enabled in server mode.
>

I think the name needs to be a little more specific. How about
ENABLE_BINARY_PATH_BROWSING?


>
>>
>> - I think we need some hint text. How about something like:
>>
>> Enter the directory in which the psql, pg_dump, pg_dumpall, and
>> pg_restore utilities can be found for the corresponding database server
>> version. The default path will be used for server versions that do not have
>> a path specified.
>>
>
>     I have added the hint in two ways, please refer to the screenshots
> below and let me know your prefered one.
>          [image: Screenshot 2021-05-21 at 2.16.57 PM.png].        [image:
> Screenshot 2021-05-21 at 2.23.50 PM.png]
>

I think having the text below is better. It's more consistent with other
controls.


-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com


Attachments:

  [image/png] Binary_Path.png (323.2K, 3-Binary_Path.png)
  download | view image

  [image/png] Screenshot 2021-05-21 at 2.16.57 PM.png (296.9K, 4-Screenshot%202021-05-21%20at%202.16.57%20PM.png)
  download | view image

  [image/png] Screenshot 2021-05-21 at 2.23.50 PM.png (293.2K, 5-Screenshot%202021-05-21%20at%202.23.50%20PM.png)
  download | view image

view thread (14+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Feature #5370 User should be able to set the binary path for each database server
  In-Reply-To: <CA+OCxoz-28ghNLD3wq6XpwnY+uLf4Ve0OsL2o46TrE-w5PEjZw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox