public inbox for [email protected]  

help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website
Date: Wed, 26 Aug 2020 11:36:17 +0100
Message-ID: <CA+OCxoz3GCjXSd5jQL44mGK5T80Zzfm5h2Q+XrikEVipdDoiwg@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0APsOizjnj-D2dCAfwbbobwgJ4mFcjtyJEuwh3QborQiUQ@mail.gmail.com>
References: <CAOBg0ANnFFsknDcF6NfLaDVc6x1EFwf_KUO+gbKtR7qvyfAY5A@mail.gmail.com>
	<CAOBg0AOcPNT69=Eqd22sNChWUGz6HpMt1qXrs4_pgCP6sO0H7Q@mail.gmail.com>
	<CA+OCxoy_TUdmca3pB1hgnRKniwQ8-XsKD_2uVTZW9BnTiVuGEA@mail.gmail.com>
	<CAOBg0AM8coLjoYL6kUirbo+5cmm9VhqXp0SH_FgRyzekBaPOtA@mail.gmail.com>
	<CA+OCxozx6vJFM20CVn0VZrdC9LLOjGiN4_zZQ6i23_6anBpRmg@mail.gmail.com>
	<CAOBg0APy7ONbPTFSHFqcvtYzDNKc7dSgv1Qz+Cg7kb_mF9p7gg@mail.gmail.com>
	<CA+OCxox4MRytMEN_XKnoF1t99Lxf-2JnJvy-f+Ux1P9Fp0aBzQ@mail.gmail.com>
	<CAOBg0AOd-8t_KaSxfMGpBMCkEHTEwoSBV4nOmvVVbG6rF+GUGg@mail.gmail.com>
	<CA+OCxoyKCp-uvuOVi7ZKvhjAAaqVqRu6YiSZpZ0mDvrFctaQiQ@mail.gmail.com>
	<CAOBg0APsOizjnj-D2dCAfwbbobwgJ4mFcjtyJEuwh3QborQiUQ@mail.gmail.com>

Thanks, applied with a few changes for consistency in the titles and 404
handling.

On Wed, Aug 26, 2020 at 8:23 AM Nikhil Mohite <
[email protected]> wrote:

> Hi Dave/Team,
>
> Updated the implementation for the set title of the page, for this, I have
> done a few changes in the flow.
> 1. Earlier we are using {% include %} for showing pages in the base
> page (styleguide/index.html) for a style guide but in the Django template
> we can't use {% block %} statement if we are adding page using "{% include
> %}".
> 2. To overcome this issue now using {% extends %} instead of  {% include
> %},  For this added dynamic URL generation in views so instead of loading
> "index.html" of style guide we are loading specific component HTML file
> (e.g: typography.html) and that template extends the "index.html" of the
> style guide.
>
> PFA v6 patch for the same.
>
> If required any changes please let me know.
>
> Regards,
> Nikhil Mohite.
>
>
> On Tue, Aug 25, 2020 at 7:09 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Tue, Aug 25, 2020 at 12:49 PM Nikhil Mohite <
>> [email protected]> wrote:
>>
>>>
>>> PFA v5 patch for the same.
>>>
>>> if required any updates in this please let me know.
>>>
>>
>> Hmm, yeah - that doesn't work for me I'm afraid; it's mixing content with
>> code.
>>
>> The titles should be defined in the HTML pages themselves. We do that
>> everywhere else by including a template block like the following in the
>> lowest level content:
>>
>> {% block title %}Contributing{% endblock %}
>>
>> And then in base.html:
>>
>> <title>{% block title %}{% endblock %}</title>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com


view thread (13+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website
  In-Reply-To: <CA+OCxoz3GCjXSd5jQL44mGK5T80Zzfm5h2Q+XrikEVipdDoiwg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox