public inbox for [email protected]
help / color / mirror / Atom feed[Patch] Rename feature test server
2+ messages / 2 participants
[nested] [flat]
* [Patch] Rename feature test server
@ 2017-04-27 21:22 Sarah McAlear <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Sarah McAlear @ 2017-04-27 21:22 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers!
We realized that the feature tests and unit tests were using the same
server, which was causing some flakiness when running the tests. This patch
renames the server for the feature tests.
Thanks!
Joao & Sarah
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] 0001-Change-the-name-of-the-Server-created-for-Feature-te.patch (1.3K, 3-0001-Change-the-name-of-the-Server-created-for-Feature-te.patch)
download | inline diff:
From 0672de780c506cd1ca885a55a7bf0cc5f2f9b0ab Mon Sep 17 00:00:00 2001
From: Joao Pereira and Sarah McAlear <[email protected]>
Date: Thu, 27 Apr 2017 17:14:10 -0400
Subject: [PATCH] Change the name of the Server created for Feature tests
[#144055953]
---
web/regression/feature_utils/base_feature_test.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/web/regression/feature_utils/base_feature_test.py b/web/regression/feature_utils/base_feature_test.py
index dc704e8e..89954290 100644
--- a/web/regression/feature_utils/base_feature_test.py
+++ b/web/regression/feature_utils/base_feature_test.py
@@ -13,6 +13,8 @@ import os
from datetime import datetime
+from copy import deepcopy
+
import config as app_config
from pgadmin.utils.route import BaseTestGenerator
from regression.feature_utils.pgadmin_page import PgadminPage
@@ -22,6 +24,8 @@ class BaseFeatureTest(BaseTestGenerator):
CURRENT_PATH = os.path.dirname(os.path.realpath(__file__))
def setUp(self):
+ self.server = deepcopy(self.server)
+ self.server['name'] += ' Feature Tests'
if app_config.SERVER_MODE:
self.skipTest("Currently, config is set to start pgadmin in server mode. "
"This test doesn't know username and password so doesn't work in server mode")
--
2.12.0
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [Patch] Rename feature test server
@ 2017-05-02 11:00 Dave Page <[email protected]>
parent: Sarah McAlear <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2017-05-02 11:00 UTC (permalink / raw)
To: Sarah McAlear <[email protected]>; +Cc: pgadmin-hackers
Thanks, applied.
On Thu, Apr 27, 2017 at 10:22 PM, Sarah McAlear <[email protected]> wrote:
> Hi Hackers!
>
> We realized that the feature tests and unit tests were using the same
> server, which was causing some flakiness when running the tests. This patch
> renames the server for the feature tests.
>
> Thanks!
> Joao & Sarah
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2017-05-02 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 21:22 [Patch] Rename feature test server Sarah McAlear <[email protected]>
2017-05-02 11:00 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox