public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab
@ 2019-01-09 10:38 Akshay Joshi <[email protected]>
2019-01-10 06:11 ` Re: [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab Dave Page <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Akshay Joshi @ 2019-01-09 10:38 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is the patch to fix RM #3842 pg_catalogs schema should not
displayed in properties tab.
Please review it.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachments:
[application/octet-stream] RM_3842.patch (4.0K, 3-RM_3842.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/gpdb_5.0_plus/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/gpdb_5.0_plus/sql/properties.sql
index cce103ca..f6c2d923 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/gpdb_5.0_plus/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/gpdb_5.0_plus/sql/properties.sql
@@ -29,9 +29,8 @@ WHERE
{% if scid %}
nsp.oid={{scid}}::oid AND
{% else %}
- {% if show_sysobj %}
- nspname NOT LIKE E'pg\\_temp\\_%' AND
- nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+ {% if not show_sysobj %}
+ nspname NOT LIKE E'pg\\_%' AND
{% endif %}
{% endif %}
NOT (
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/9.2_plus/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/9.2_plus/sql/properties.sql
index ca2254d0..a99e0509 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/9.2_plus/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/9.2_plus/sql/properties.sql
@@ -46,9 +46,8 @@ WHERE
{% if scid %}
nsp.oid={{scid}}::oid AND
{% else %}
- {% if show_sysobj %}
- nspname NOT LIKE E'pg\\_temp\\_%' AND
- nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+ {% if not show_sysobj %}
+ nspname NOT LIKE E'pg\\_%' AND
{% endif %}
{% endif %}
NOT (
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/default/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/default/sql/properties.sql
index fcb25ded..9335cd10 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/default/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/default/sql/properties.sql
@@ -40,9 +40,8 @@ WHERE
{% if scid %}
nsp.oid={{scid}}::oid AND
{% else %}
- {% if show_sysobj %}
- nspname NOT LIKE E'pg\\_temp\\_%' AND
- nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+ {% if not show_sysobj %}
+ nspname NOT LIKE E'pg\\_%' AND
{% endif %}
{% endif %}
NOT (
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.1_plus/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.1_plus/sql/properties.sql
index 41e681a5..965e27af 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.1_plus/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.1_plus/sql/properties.sql
@@ -39,9 +39,8 @@ WHERE
{% if scid %}
nsp.oid={{scid}}::oid AND
{% else %}
- {% if show_sysobj %}
- nspname NOT LIKE E'pg\\_temp\\_%' AND
- nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+ {% if not show_sysobj %}
+ nspname NOT LIKE E'pg\\_%' AND
{% endif %}
{% endif %}
nsp.nspparent = 0 AND
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.2_plus/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.2_plus/sql/properties.sql
index d32e8c27..5d2f3682 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.2_plus/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.2_plus/sql/properties.sql
@@ -46,9 +46,8 @@ WHERE
{% if scid %}
nsp.oid={{scid}}::oid AND
{% else %}
- {% if show_sysobj %}
- nspname NOT LIKE E'pg\\_temp\\_%' AND
- nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+ {% if not show_sysobj %}
+ nspname NOT LIKE E'pg\\_%' AND
{% endif %}
{% endif %}
nsp.nspparent = 0 AND
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab
2019-01-09 10:38 [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab Akshay Joshi <[email protected]>
@ 2019-01-10 06:11 ` Dave Page <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2019-01-10 06:11 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers
Hi
On Wed, Jan 9, 2019 at 4:09 PM Akshay Joshi <[email protected]>
wrote:
> Hi Hackers,
>
> Attached is the patch to fix RM #3842 pg_catalogs schema should not
> displayed in properties tab.
>
> Please review it.
>
Thanks, applied.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-01-10 06:11 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-09 10:38 [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab Akshay Joshi <[email protected]>
2019-01-10 06:11 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox