public inbox for [email protected]
help / color / mirror / Atom feedFrom: Thom Brown <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: Harshal Dhumal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [PATCH] Tables node (pgAdmin4)
Date: Wed, 25 May 2016 02:12:29 +0100
Message-ID: <CAA-aLv5aaSGcDodnguBdjfGAdZGmGa_7_szfrJSKZHiqvAp_Pw@mail.gmail.com> (raw)
In-Reply-To: <CAA-aLv758RATV2O4QpO+zXVkiFK0p7AqR86EBtS71JJht=ek_w@mail.gmail.com>
References: <CAKKotZRCf07F_SGHi4KawBtLHPSeKz5Uvzwu6ddQ=bKc1FDRRw@mail.gmail.com>
<CAFiP3vw61T0n--F4vYXALdtrkBKznBegBPq5Ds=6uZrg02vWXQ@mail.gmail.com>
<CAFOhELea6nCtX_T78o_3mNKJC0_emirXKGm3nq8d6mvSZV57pg@mail.gmail.com>
<CAFiP3vypf7KEmToKsBqn1--qf_PzMV+p-d9bsMj04eoYnj5_tQ@mail.gmail.com>
<CAKKotZQumWW_cvhvgyFc7_1Lvs8npkPW57FgVN_+wPPSurBDOw@mail.gmail.com>
<CAKKotZQMR5zsbDAiAhUEQ46yhNE51BONu0DYjEY1WFSJbBqK+w@mail.gmail.com>
<CAFiP3vwBUX5Ez51Fk_s+t67hRW-uZ6ViMcuTg4e+oPf+k5KqTg@mail.gmail.com>
<CAFOhELdg9-TB=fdpGDLNkjYve9vBxYttE_PzmahsrNMQv4nn4Q@mail.gmail.com>
<CAFiP3vxO9tej3WXYeLjZk6MgQYR0C-hp9UUWmog1E7iDvvqFmQ@mail.gmail.com>
<CAFOhELd=_vuqwR0eGLL=KhxGaQCP6n9mcXP1GijcWh1ecCpegw@mail.gmail.com>
<CAFiP3vw5nx2Wdt9ci-MNRV+H+dO-x9KUSZtk16EZKjdox+KRxg@mail.gmail.com>
<CAFiP3vz9=gtNuoGEt+oxt+UYfE=7=dTUQZpCxgGkVWUhS=Kafw@mail.gmail.com>
<CA+yw=mPp8CY+jd3FUXeV-KSd+82dztXYWySJVLuL9eoE9hrbfQ@mail.gmail.com>
<CAFiP3vw+yN2kYktjdmJEHL8Ug8R+k_HxhN+E+pozpC=d_zs1=Q@mail.gmail.com>
<CAKKotZQKV3nkCz8ADOV1ExoSaKWHdH4rY17xW9K3B-4qLree3Q@mail.gmail.com>
<CAKKotZTiR-cUVTbH21WnYbHW3EaQ3J_zESyYrkL+wO4sKNSSGg@mail.gmail.com>
<CAKKotZQyTOK4tZYQ2kk4_G-4GknU+uDVu3PaU5FDeJuCe=ywDw@mail.gmail.com>
<CAM5-9D9R6fT9LOhCBoSbcBvzKpWcjZvN23-wHRTJKsvQqNPECA@mail.gmail.com>
<CAFiP3vwY_cAx9b-BoxteX5+7fcxVvu+LY4y5ooy28bxvz7D8AA@mail.gmail.com>
<CAFiP3vwfO=udZvVPdXuEnem9A2LN7MBEQt02VW1AJLuCEsRL2w@mail.gmail.com>
<CANxoLDcJ-Qum-BJXtDx52ij72EJVzLE+XYFE+_skJF4fXVJ9jA@mail.gmail.com>
<CA+OCxowB=LJKts18wKx982gF4ZNJnOamND0xZEMp0CnTrjeruA@mail.gmail.com>
<CAG7mmoyD5vJ3_FS6RO5kmer=CWyRW5Lgr723denYxLM-K00eow@mail.gmail.com>
<[email protected]>
<CAKKotZS9MbvFpSkYtRfcLZ8_2drrMpL8T-btH4QXf-BPL0cYzQ@mail.gmail.com>
<CAG7mmoxJHcTrTFKJGmtVLz-Wix0xpqOmcpHxs141N_Bbx4X7VQ@mail.gmail.com>
<CAA-aLv46ECN_NZJ=Uercv7mvE+s=vceXqZsb32Qfnh_Oq6OhcA@mail.gmail.com>
<CAA-aLv758RATV2O4QpO+zXVkiFK0p7AqR86EBtS71JJht=ek_w@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On 25 May 2016 at 02:00, Thom Brown <[email protected]> wrote:
> On 25 May 2016 at 00:29, Thom Brown <[email protected]> wrote:
>> On 24 May 2016 at 19:09, Ashesh Vashi <[email protected]> wrote:
>>>
>>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala
>>> <[email protected]> wrote:
>>>>
>>>> Hi,
>>>>
>>>> PFA patch, which will fixes below mentioned issues,
>>>
>>> Committed.
>>
>>
>> In the Create Table dialog, on the Advanced tab, the "Of type" drop-down
>> lists tables and composite types, but those are supposed to just be
>> composite types.
>>
>> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so LIKE should
>> be disabled when using OF. Also, there should probably be a way of setting
>> options for the columns taken from the composite type. For example:
>>
>> CREATE TYPE inventory AS (product_id bigint, product_name text, weight
>> numeric);
>>
>> CREATE TABLE stock OF inventory (
>> PRIMARY KEY (product_id),
>> weight WITH OPTIONS DEFAULT 0
>> );
>>
>> There's currently no way of doing this (neither the primary key, nor the
>> default value for any columns). It should probably automatically populate
>> the columns from the composite type on the columns tab.
>>
>> Also, could the generated SQL have an empty line between each statement?
>
> Another thing I've noticed is that, when adding columns, the "Is
> primary key?" column is greyed out. Why not just make those
> modifiable in that view rather than having to go into the details for
> each column?
>
> When there's something that hasn't been set up correctly, like adding
> variables for a column, but not actually selecting a variable, the SQL
> pane, correctly, doesn't show an output, but the error message,
> "Please provide input for variable." isn't enough to identify what
> needs checking. Could the relevant tab and field/row be
> highlighted/coloured in red/bold? This is more general, so doesn't
> just apply to the create table dialog.
Last issue today:
When using "Of type", it's not valid to allow additional columns to be
added, so those should be prevented.
Thom
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (49+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Tables node (pgAdmin4)
In-Reply-To: <CAA-aLv5aaSGcDodnguBdjfGAdZGmGa_7_szfrJSKZHiqvAp_Pw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox