public inbox for [email protected]
help / color / mirror / Atom feedFrom: Magnus Hagander <[email protected]>
To: Andreas 'ads' Scherbaum <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Remove "unsupported version" warning for Greenplum
Date: Thu, 21 Jan 2016 23:54:52 +0100
Message-ID: <CABUevExjUYGAfHdPbc_P=iFjrdKwy8_7gX5S431wFke0WxY+Gg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CA+OCxoxZQzjb5OMRGJp+WiYLhEpvGqer-QLLhutRivea575KvA@mail.gmail.com>
<[email protected]>
<CA+OCxozqNONmJBPAf0QCaQCLhAidrWGrb3eBvveb8t7388L3=g@mail.gmail.com>
<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Thu, Jan 21, 2016 at 11:35 PM, Andreas 'ads' Scherbaum <
[email protected]> wrote:
> On 21.01.2016 10:31, Dave Page wrote:
>
>> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum
>> <[email protected]> wrote:
>>
>>> On 19.01.2016 16:03, Dave Page wrote:
>>>
>>>>
>>>>
>>>> Your patch won't apply again. I have no idea why - I'm trying to do it
>>>> on my Mac, which is a *nix under the hood (they don't use Mac line
>>>> endings any more - that was the old Mac OS 9 and earlier from a decade
>>>> or so ago iirc). How are you creating them? The normal way is to do
>>>> something like:
>>>>
>>>
>>>
>>> And how does the attached work? Fresh clone again, only difference is a
>>> warning (not an error) for whitespaces removed.
>>>
>>
>> Still doesn't apply. I tried on the following systems:
>>
>> Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
>> Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
>> CentOS release 6.7 (Final) - git version 1.7.1
>>
>> I'm fairly convinced at this stage that there's something funky on
>> your system. Perhaps we should take a look next week when we're both
>> in Brussels?
>>
>>
> After debugging back and forth with Magnus, it looks like that Google Mail
> is fooling you. Your downloaded file has a different line ending, and your
> file is 3269 bytes, where the original file is 3210 bytes. That's 59
> additional line breaks.
>
> 4fa0990a1020e425fe95b99ea9f186de gp-warning2.diff
>
> The file you download from the archive:
>
> http://www.postgresql.org/message-id/[email protected]
>
> is also correct.
It's also worth noticing that "patch" has no problem with either of the two
files, but "git apply" does. At least on my system.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
view thread (16+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Remove "unsupported version" warning for Greenplum
In-Reply-To: <CABUevExjUYGAfHdPbc_P=iFjrdKwy8_7gX5S431wFke0WxY+Gg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox