public inbox for [email protected]
help / color / mirror / Atom feedFrom: Neel Patel <[email protected]>
To: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab
Date: Tue, 9 May 2017 13:58:55 +0530
Message-ID: <CACCA4P0GHHgwugezQr6pVjDSmwTtNosGsmWqfMg_1wE5pRb5Rw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozBE2PLLytr+8EmzMLwF_ax6xUTKcKpsN6+MYc6HWOHiQ@mail.gmail.com>
References: <CACCA4P3zyGfc7nFLCCiq8O4OU=ErTkmvR=mYMOQOao2-T_RJ_A@mail.gmail.com>
<CA+OCxozAs+3T-Z_rJeZd0TLDr4gbWZdhPi4pYq8UUbM0nqLzVA@mail.gmail.com>
<CANxoLDcQV7socMUmvXxL0V-E=W9LUoYzmgoMRb-s1FyYtOzrXw@mail.gmail.com>
<CA+OCxoz6QVHNEph0ENhJhttVMm6vw=b5DmoJ7HY_05M7EF-qGQ@mail.gmail.com>
<CANxoLDfXWm2482su98nXVVOvuRQMSPCn5OfX+MU_G0LE0hZpUQ@mail.gmail.com>
<CA+OCxozBE2PLLytr+8EmzMLwF_ax6xUTKcKpsN6+MYc6HWOHiQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Dave,
Yes, It looks like compilation fails on Qt4. We will fix this issue but
which version of Qt4 we are using in Jenkins ?
Thanks,
Neel Patel
On Tue, May 9, 2017 at 1:56 PM, Dave Page <[email protected]>
wrote:
>
>
> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <
> [email protected]> wrote:
>
>> Hi
>>
>> On Tue, May 9, 2017 at 1:42 PM, Dave Page <[email protected]>
>> wrote:
>>
>>> This appears to have made Jenkins get all angry and red :-(
>>>
>>> https://jenkins.pgadmin.org/
>>>
>>
>> We(Neel and I) have tested it and working fine.
>>
>
> It clearly doesn't compile on QT4. Please review the Jenkins logs.
>
>
>>
>>>
>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Thanks patch applied.
>>>>
>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Akshay, could you review this please?
>>>>>
>>>>> Thanks.
>>>>>
>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find attached patch file with the fix of RM #2328 - [Runtime]:
>>>>>> Unable to launch query tool and debugger in new browser tab.
>>>>>>
>>>>>> I have used Qt 5.8 with webkit mentioned in below URL.
>>>>>>
>>>>>> https://github.com/annulen/webkit/releases
>>>>>>
>>>>>>
>>>>>> As there was a bug in QWebKit regarding "unload" event. We have
>>>>>> raised and also they have provided patch file to fix this issue. I have
>>>>>> applied the patch in linux and compile the webkit and tested the attached
>>>>>> patch with compiled webkit which is now working fine.
>>>>>>
>>>>>> Below is the link for reference regarding unload issue. They have
>>>>>> provided test webkit release for Mac in below URL but for other platform we
>>>>>> need to apply the patch and compile the webkit until they provide
>>>>>> webkit-releases for all platforms.
>>>>>>
>>>>>> https://github.com/annulen/webkit/issues/519
>>>>>>
>>>>>> Do review it and let me know in case of any issue.
>>>>>>
>>>>>> Thanks,
>>>>>> Neel Patel
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sent via pgadmin-hackers mailing list ([email protected]
>>>>>> )
>>>>>> To make changes to your subscription:
>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Akshay Joshi*
>>>> *Principal Software Engineer *
>>>>
>>>>
>>>>
>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>>> 976-788-8246 <+91%2097678%2088246>*
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> VP, Chief Architect, Tools & Installers
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab
In-Reply-To: <CACCA4P0GHHgwugezQr6pVjDSmwTtNosGsmWqfMg_1wE5pRb5Rw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox