Re: RM4292 - Dark mode support for Windows/macOS

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Neel Patel <[email protected]>
To: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: RM4292 - Dark mode support for Windows/macOS
Date: Wed, 22 Apr 2020 17:25:37 +0530
Message-ID: <CACCA4P3ujOtirG4NPb4SUHzLPoCHvQgWkBQKCvntTBzEF-xCiA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoz61tkr07PzdpC7H-tDGMC=jspstDw8i-zsqQ6vJt5Egg@mail.gmail.com>
References: <CA+OCxoyiLYcN0N00nFPT9YCOFo8HT47rcoidccq2N5fDJFuqtQ@mail.gmail.com>
	<CANxoLDdFpBpAg_V5r5M2ni9ycQzr-vhRkeQmMUfqEMYZXq-pZw@mail.gmail.com>
	<CACCA4P1U8iLJWDM4_by0+HC9oPyUrrfArsu522FgWC6+sjjzWA@mail.gmail.com>
	<CA+OCxowhYTCS0g7q=9BVi-Nd0=++3dWugAeZQTRzEVikwSdosA@mail.gmail.com>
	<CACCA4P0L-0PS_8-9i-sa4ECvH16kK6eJSgUcMHP57fTyzBHCBA@mail.gmail.com>
	<CA+OCxoyC1+id7C8ii5A+sfE8Kc+SQSNMrQ1FtGqn7hOaJG_MGg@mail.gmail.com>
	<CACCA4P1RUSK+7=nYB6gf9oKNOa=QoaDSdUBt06LMaw2VOdFyFA@mail.gmail.com>
	<CA+OCxox-df5Jx_68SJ=zbaXsWCZ9drH5WnTAiL0wdc0v3X_VgA@mail.gmail.com>
	<CACCA4P2VRQLbhzyrWFUHXTy+Jw-+dg3nMXkruFgLJ8zLxd2Gug@mail.gmail.com>
	<CANxoLDfvbYdS6UiCzUUdM4dyOiSqdNZV=ScM5dnse22O_hjPQw@mail.gmail.com>
	<CACCA4P2uc3JxMyPMJHTh=S-JQXCGWZi=Jiza2BtTNi=h9e+RTQ@mail.gmail.com>
	<CA+OCxoz61tkr07PzdpC7H-tDGMC=jspstDw8i-zsqQ6vJt5Egg@mail.gmail.com>

yes, as i have tested on my local env without those files and it worked. So
now those staging files for dark themes are not required ( *.qss,
dark/*.svg, light/*.svg etc )  as qss are bundled within the application
itself. If we copy those files along with the application and change the
QSS, it is not affecting any Qt controls. At compile time, whatever the qss
embedded to application, that will be applied.

Thanks,
Neel Patel

On Wed, Apr 22, 2020 at 5:12 PM Dave Page <[email protected]> wrote:

> Doesn't that revert the previous patch that copied all the required files
> into the staging directory?
>
> On Wed, Apr 22, 2020 at 12:40 PM Neel Patel <[email protected]>
> wrote:
>
>> Hi,
>>
>> After debugging, I found that the required image formats Qt plugin was
>> missing in bundling and due to that "checkbox" images or all images were
>> not rendered from qss files. It was working fine in my local development
>> environment because all required plugins to load the images are present. I
>> have attached the patch for windows and Mac. Can you please review ? I will
>> verify once snapshot build is available.
>>
>> Thanks,
>> Neel Patel
>>
>> On Mon, Apr 20, 2020 at 7:19 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, patch applied without testing it.
>>>
>>> On Mon, Apr 20, 2020 at 6:59 PM Neel Patel <[email protected]>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> In windows, I am able to reproduce it with my dev environment and after
>>>> copying "Qt5Svg.dll", it renders the checkbox and for Mac build, we should
>>>> copy theme components in "Resources" folder which might solve the problem
>>>> and update the patch accordingly.
>>>> Once snapshot build is ready, I will verify with the same. Do review it.
>>>>
>>>> Thanks,
>>>> Neel Patel
>>>>
>>>> On Wed, Apr 15, 2020 at 7:12 PM Dave Page <[email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Wed, Apr 15, 2020 at 2:11 PM Neel Patel <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> On Wed, Apr 15, 2020 at 5:04 PM Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> On Thu, Apr 9, 2020 at 5:56 PM Neel Patel <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>    - Checkbox is not visible in Configure window UI as per below
>>>>>>>>>>    screenshot. Are you able to see on Mac ? If no, I can take a look at it.
>>>>>>>>>>
>>>>>>>>>> [image: Screenshot 2020-04-09 at 5.05.25 PM.png]
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> No, that works on Mac. If you can look at it that would be great
>>>>>>>>> (are the SVGs from the patch in your filesystem?):
>>>>>>>>>
>>>>>>>>
>>>>>>>> Yes, all SVGs from the patch are there. I will take a look.
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> [image: Screenshot 2020-04-09 at 17.47.39.png]
>>>>>>>>>
>>>>>>>>
>>>>>>> So interestingly, with the snapshot build I now see this:
>>>>>>>
>>>>>>> [image: Screenshot 2020-04-15 at 12.34.02.png]
>>>>>>>
>>>>>>> Any idea what's going on?
>>>>>>>
>>>>>>
>>>>>> All svg files and qss reside along with the application ?
>>>>>> Initially I got this issue and when I copied the qss and svg files
>>>>>> along with the application, it resolved the issue but again I will
>>>>>> double-check and update on this.
>>>>>>
>>>>>
>>>>> Actually, no - I don't see them in the appbundle.
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


Attachments:

  [image/png] Screenshot 2020-04-09 at 5.05.25 PM.png (74.0K, 3-Screenshot%202020-04-09%20at%205.05.25%20PM.png)
  download | view image

  [image/png] Screenshot 2020-04-09 at 17.47.39.png (398.3K, 4-Screenshot%202020-04-09%20at%2017.47.39.png)
  download | view image

  [image/png] Screenshot 2020-04-15 at 12.34.02.png (455.0K, 5-Screenshot%202020-04-15%20at%2012.34.02.png)
  download | view image

view thread (26+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: RM4292 - Dark mode support for Windows/macOS
  In-Reply-To: <CACCA4P3ujOtirG4NPb4SUHzLPoCHvQgWkBQKCvntTBzEF-xCiA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox