public inbox for [email protected]
help / color / mirror / Atom feedFrom: Joao De Almeida Pereira <[email protected]>
To: Dave Page <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
Date: Fri, 16 Mar 2018 11:40:06 +0000
Message-ID: <CAE+jja=eDcstiFoN8OwXDya0rObUGtFESA0S7AsCBBTXDvDPMg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowxmnhgJ_wQEq0fLqKyoXk2ja_goWTb+W-B4HE3XNfM6Q@mail.gmail.com>
References: <[email protected]>
<CAG7mmozECtBM6SrZ6pYLbUmH4HWN-quSa8dCiivADVW9tA+bBw@mail.gmail.com>
<CA+OCxowU18WyHVM5k5xUAU4V0kQkLNnVG8tk9e3-O6Vcu_d3aQ@mail.gmail.com>
<CAKKotZQOT61K1W-MVBsoF8BPcUyF5+yEakz-uSX4G=L3ogdqTw@mail.gmail.com>
<CA+OCxoyZ9X2xdQ0Xd9ouPCVFqY8TsoXR4n_ijVfcXOMhWY5tdQ@mail.gmail.com>
<CAKKotZQj_FR9hibMai5G6Ps7vFQykXDtA2noLuGJKA_mDS_MUQ@mail.gmail.com>
<CA+OCxowxmnhgJ_wQEq0fLqKyoXk2ja_goWTb+W-B4HE3XNfM6Q@mail.gmail.com>
Hello,
Personally I believe we should fix the config_local pep issues and just
ignore the migrations. Specially because the migration file should not have
a lot of python code.
Thanks
On Thu, Mar 15, 2018 at 3:32 PM Dave Page <[email protected]> wrote:
> On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I have just noticed, we're ignoring migrations directory too.
>>>>>> Should we not also check code styling for migrations directory?
>>>>>>
>>>>>
>>>>> Yeah, I was going to ask about that :-). Is there a specific reason
>>>>> why we're ignoring the migrations Murtuza?
>>>>>
>>>> To ease writing long SQL's.
>>>>
>>>>
>>>
>>> Perhaps we could just skip the long line check for those files?
>>>
>> We have to create separate config for that and then run pycodestyle
>> using that config for migration.
>>
>> 1) pycodestyle --config=.pycodestyle
>> 2) pycodestyle --config=.pycodestyle_migration
>>
>> something like that, Because I checked the documentation and I didn't
>> find any option to have single config file for individual directories.
>>
>
> Urgh. I suppose we could keep a config file in the migration directory,
> but even then, we'll get two sets of stats out for running two tests.
>
>
>>
>>
>>>
>>>>
>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Thanks & Regards,
>>>>>>
>>>>>> Ashesh Vashi
>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>> <http://www.enterprisedb.com;
>>>>>>
>>>>>>
>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>>
>>>>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Ignore config_local.py and config_distro.py when running PEP-8
>>>>>>> checks.
>>>>>>>
>>>>>>> Branch
>>>>>>> ------
>>>>>>> master
>>>>>>>
>>>>>>> Details
>>>>>>> -------
>>>>>>>
>>>>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b0...
>>>>>>>
>>>>>>> Modified Files
>>>>>>> --------------
>>>>>>> web/.pycodestyle | 2 +-
>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
In-Reply-To: <CAE+jja=eDcstiFoN8OwXDya0rObUGtFESA0S7AsCBBTXDvDPMg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox