public inbox for [email protected]  

help / color / mirror / Atom feed

From: Joao De Almeida Pereira <[email protected]>
To: Dave Page <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations
Date: Mon, 26 Mar 2018 18:42:53 +0000
Message-ID: <CAE+jjan-6g58Kem0Zi5D0cBg3aTrkgsjsi5nMA4OPEb52z-Pig@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxow84Sigyn=2QQj4RKEV8ManXNqrg4kSmvhxgvbiFn8cpw@mail.gmail.com>
References: <CAFOhELc-ST96E35Wcih=uXuXYe5ahnb4Qp+WWAYFPDBP1XTr=g@mail.gmail.com>
	<CA+OCxow84Sigyn=2QQj4RKEV8ManXNqrg4kSmvhxgvbiFn8cpw@mail.gmail.com>

Hi Khushboo,

Looks like you have a typo on your CSS where it reads 'zoomeIn' it should
be 'zoomIn'.
Also setting more parameters into the window, in our experience, is never
good, so maybe it is time to create a real settings cache that can retrieve
from the backend the settings, like this one.

Thanks
Victoria & Joao

On Mon, Mar 26, 2018 at 8:38 AM Dave Page <[email protected]> wrote:

> Hi
>
> On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM #1978: Add an option to allow
>> user to disable alertifyjs and acitree animations.
>>
>
> I think these really need to be per-user settings, not per-installation..
> Whether or not animations are shown is really a matter of personal taste
> and circumstance.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations
  In-Reply-To: <CAE+jjan-6g58Kem0Zi5D0cBg3aTrkgsjsi5nMA4OPEb52z-Pig@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox