public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][Patch]: SQL Tab Validation
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch]: SQL Tab Validation
@ 2016-05-03 10:16 Khushboo Vashi <[email protected]>
  2016-05-10 07:06 ` Re: [pgAdmin4][Patch]: SQL Tab Validation Ashesh Vashi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Khushboo Vashi @ 2016-05-03 10:16 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

Do not send the request to the server if a model contains any error on
selection of the SQL Tab, while creating/updating any Node.

Please find the attached patch for the same.

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_sqltab_validation.patch (814B, 3-pgAdmin4_sqltab_validation.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index ab2f2fb..dbdd6cc 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1394,8 +1394,9 @@
       // Fetch the information only if the SQL tab is visible at the moment.
       if (this.dialog && obj.shown == this.tabIndex) {
 
-        // We will send request to sever only if something is changed in model
-        if(this.model.sessChanged()) {
+        // We will send a request to the sever only if something has changed
+        // in a model and also it does not contain any error.
+        if(this.model.sessChanged() && _.size(this.model.errorModel.attributes) == 0) {
 
           var self = this,
             node = self.field.get('schema_node'),


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][Patch]: SQL Tab Validation
  2016-05-03 10:16 [pgAdmin4][Patch]: SQL Tab Validation Khushboo Vashi <[email protected]>
@ 2016-05-10 07:06 ` Ashesh Vashi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Ashesh Vashi @ 2016-05-10 07:06 UTC (permalink / raw)
  To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers

Thanks - committed after few tweaks.
We will show 'incomplete definition' message instead of 'no change', which
was included in your patch.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;

On Tue, May 3, 2016 at 3:46 PM, Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Do not send the request to the server if a model contains any error on
> selection of the SQL Tab, while creating/updating any Node.
>
> Please find the attached patch for the same.
>
> Thanks,
> Khushboo
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2016-05-10 07:06 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-05-03 10:16 [pgAdmin4][Patch]: SQL Tab Validation Khushboo Vashi <[email protected]>
2016-05-10 07:06 ` Ashesh Vashi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox