public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Harshal Dhumal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell
Date: Tue, 22 Jan 2019 15:02:15 +0530
Message-ID: <CAFOhELdPrasPKUJOrME6xL2L5htHtP-024nhm6MWDqPcdu9vtA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcWuteUe_EqLok3orCNrLg3diweC79Zi+mx_-AX6Np26A@mail.gmail.com>
References: <CAFiP3vyvLc8GEdBAO5sV0swVJghi_QEysdTj10MCkP0X56K2ZA@mail.gmail.com>
	<CANxoLDcWuteUe_EqLok3orCNrLg3diweC79Zi+mx_-AX6Np26A@mail.gmail.com>

Hi Harshal,

The Selec2Cell and PrivilegeCell are working properly but I think we should
also consider below:

1. The Backgrid and sub-node should have accessibility including every
button, cell and control.
2. The Backgrid table header is accessible through keyboard but it should
be highlighted when it gets focus.

@Akshay, we can commit this patch but we should create the separate RM for
above fixes.

Thanks,
Khushboo


On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi <[email protected]>
wrote:

> Hi Khushboo
>
> Can you please review it.
>
> On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal <
> [email protected]> wrote:
>
>> Hi,
>> Please find attached patch to fix backgrid navigation using keyboard
>> for Select2Cell and PrivilegeCell
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell
  In-Reply-To: <CAFOhELdPrasPKUJOrME6xL2L5htHtP-024nhm6MWDqPcdu9vtA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox