public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Harshal Dhumal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell
Date: Tue, 22 Jan 2019 16:37:51 +0530
Message-ID: <CANxoLDdfV_=U_P4DBuCaPTseAPnz1HEZDhfac5P=xmcR5tKE6g@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELdPrasPKUJOrME6xL2L5htHtP-024nhm6MWDqPcdu9vtA@mail.gmail.com>
References: <CAFiP3vyvLc8GEdBAO5sV0swVJghi_QEysdTj10MCkP0X56K2ZA@mail.gmail.com>
<CANxoLDcWuteUe_EqLok3orCNrLg3diweC79Zi+mx_-AX6Np26A@mail.gmail.com>
<CAFOhELdPrasPKUJOrME6xL2L5htHtP-024nhm6MWDqPcdu9vtA@mail.gmail.com>
Thanks patch applied
On Tue, Jan 22, 2019 at 3:02 PM Khushboo Vashi <
[email protected]> wrote:
> Hi Harshal,
>
> The Selec2Cell and PrivilegeCell are working properly but I think we
> should also consider below:
>
> 1. The Backgrid and sub-node should have accessibility including every
> button, cell and control.
> 2. The Backgrid table header is accessible through keyboard but it should
> be highlighted when it gets focus.
>
> @Akshay, we can commit this patch but we should create the separate RM for
> above fixes.
>
RM # 3919 has been created by Harshal.
>
> Thanks,
> Khushboo
>
>
> On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Khushboo
>>
>> Can you please review it.
>>
>> On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal <
>> [email protected]> wrote:
>>
>>> Hi,
>>> Please find attached patch to fix backgrid navigation using keyboard
>>> for Select2Cell and PrivilegeCell
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell
In-Reply-To: <CANxoLDdfV_=U_P4DBuCaPTseAPnz1HEZDhfac5P=xmcR5tKE6g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox