public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t
Date: Mon, 8 Jul 2019 11:10:30 +0530
Message-ID: <CAFOhELdhnLVQvjw7nFpHkPxMW_hTqVv6-SUotS+UPQhHtEPeWw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi,

One small change is required to support the custom schema.
Please find the attached patch for the same.

Thanks,
Khushboo

On Fri, Jul 5, 2019 at 3:35 PM Akshay Joshi <[email protected]>
wrote:

> Added logic to provide custom schema name in re_sql test framework.
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=954c0d31019a6cd19e15ee024f032f92c665...
> Author: Khushboo Vashi <[email protected]>
>
> Modified Files
> --------------
> web/regression/re_sql/tests/test_resql.py | 30
> +++++++++++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
>


Attachments:

  [application/octet-stream] re_sql_schema_fixes_v2.patch (854B, 3-re_sql_schema_fixes_v2.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tests/utils.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tests/utils.py
index e3285cf5..ae49402a 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tests/utils.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tests/utils.py
@@ -78,7 +78,7 @@ def verify_schemas(server, db_name, schema_name):
                                              server['port'],
                                              server['sslmode'])
         pg_cursor = connection.cursor()
-        pg_cursor.execute("SELECT * FROM pg_namespace sch"
+        pg_cursor.execute("SELECT oid,* FROM pg_namespace sch"
                           " WHERE sch.nspname='%s'" % schema_name)
         schema = pg_cursor.fetchone()
         connection.close()

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t
  In-Reply-To: <CAFOhELdhnLVQvjw7nFpHkPxMW_hTqVv6-SUotS+UPQhHtEPeWw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox