public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Added logic to provide custom schema name in re_sql t
4+ messages / 3 participants
[nested] [flat]
* pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t
@ 2019-07-05 10:05 Akshay Joshi <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Akshay Joshi @ 2019-07-05 10:05 UTC (permalink / raw)
To: [email protected]
Added logic to provide custom schema name in re_sql test framework.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=954c0d31019a6cd19e15ee024f032f92c665...
Author: Khushboo Vashi <[email protected]>
Modified Files
--------------
web/regression/re_sql/tests/test_resql.py | 30 +++++++++++++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t
@ 2019-07-08 05:40 Khushboo Vashi <[email protected]>
parent: Akshay Joshi <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Khushboo Vashi @ 2019-07-08 05:40 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Hi,
One small change is required to support the custom schema.
Please find the attached patch for the same.
Thanks,
Khushboo
On Fri, Jul 5, 2019 at 3:35 PM Akshay Joshi <[email protected]>
wrote:
> Added logic to provide custom schema name in re_sql test framework.
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=954c0d31019a6cd19e15ee024f032f92c665...
> Author: Khushboo Vashi <[email protected]>
>
> Modified Files
> --------------
> web/regression/re_sql/tests/test_resql.py | 30
> +++++++++++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
>
Attachments:
[application/octet-stream] re_sql_schema_fixes_v2.patch (854B, 3-re_sql_schema_fixes_v2.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tests/utils.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tests/utils.py
index e3285cf5..ae49402a 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tests/utils.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tests/utils.py
@@ -78,7 +78,7 @@ def verify_schemas(server, db_name, schema_name):
server['port'],
server['sslmode'])
pg_cursor = connection.cursor()
- pg_cursor.execute("SELECT * FROM pg_namespace sch"
+ pg_cursor.execute("SELECT oid,* FROM pg_namespace sch"
" WHERE sch.nspname='%s'" % schema_name)
schema = pg_cursor.fetchone()
connection.close()
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t
@ 2019-07-08 07:04 Akshay Joshi <[email protected]>
parent: Khushboo Vashi <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Akshay Joshi @ 2019-07-08 07:04 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Thanks patch applied
On Mon, Jul 8, 2019 at 11:10 AM Khushboo Vashi <
[email protected]> wrote:
> Hi,
>
> One small change is required to support the custom schema.
> Please find the attached patch for the same.
>
> Thanks,
> Khushboo
>
> On Fri, Jul 5, 2019 at 3:35 PM Akshay Joshi <[email protected]>
> wrote:
>
>> Added logic to provide custom schema name in re_sql test framework.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=954c0d31019a6cd19e15ee024f032f92c665...
>> Author: Khushboo Vashi <[email protected]>
>>
>> Modified Files
>> --------------
>> web/regression/re_sql/tests/test_resql.py | 30
>> +++++++++++++++++++++++++++++-
>> 1 file changed, 29 insertions(+), 1 deletion(-)
>>
>>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t
@ 2019-07-25 09:23 Dave Page <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Dave Page @ 2019-07-25 09:23 UTC (permalink / raw)
To: [email protected]
Added logic to provide custom schema name in re_sql test framework.
Branch
------
electron2
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5154f4323ced80fe45df7fd502d92e92676...
Author: Khushboo Vashi <[email protected]>
Modified Files
--------------
web/regression/re_sql/tests/test_resql.py | 30 +++++++++++++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2019-07-25 09:23 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-07-05 10:05 pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t Akshay Joshi <[email protected]>
2019-07-08 05:40 ` Khushboo Vashi <[email protected]>
2019-07-08 07:04 ` Akshay Joshi <[email protected]>
2019-07-25 09:23 pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox