public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Yosry Muhammad <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Bug in Database Nodes in the Tree
Date: Thu, 18 Jul 2019 10:57:21 +0530
Message-ID: <CAFOhELe=SxTy0mBMHOoKE+EfHVVDR0E_az2B7EkGvRaPQvowFQ@mail.gmail.com> (raw)
In-Reply-To: <CAFSMqn9bUm4SGsicbVf9_vgy9rhEXp_J5zhrXM0gBgevUffrEQ@mail.gmail.com>
References: <CAFSMqn9bUm4SGsicbVf9_vgy9rhEXp_J5zhrXM0gBgevUffrEQ@mail.gmail.com>

Hi Yosry,

On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <[email protected]> wrote:

> Hi Khushboo,
>
> There's a minor bug that I noticed a while back that when you right click
> a disconnected database (to drop it for example) it automatically connects
> to the database and expands the node. This behaviour is a little annoying
> to users (me too), I am trying to fix it.
>
> This behavior is by design as we have considered some of the pgAdmin
III behavior. One behavior we can change is that on the selection of the
database node, we can just connect it and not expand it and when we expand
the database node (by arrow icon or double click), we can connect and
expand both.

We need Dave's approval to change this.

I looked around the code in the browser module (node.js, database.js,
> menu.js) and I couldn't find a way to modify this behaviour. Is this
> handled internally by jQuery? Is modifying this behaviour feasible?
>
>
I think the problem is that the right click event triggers the left event
> click too. Am I correct?
>
> Basically, the browser tree is generated through the aciTree library, so
when required, the public APIs (provided by aciTree) of the events are
being called.
In this case, on the selection of the database node, the selected event is
used in the database.js file.

Thanks,
Khushboo

Thanks!
>

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Bug in Database Nodes in the Tree
  In-Reply-To: <CAFOhELe=SxTy0mBMHOoKE+EfHVVDR0E_az2B7EkGvRaPQvowFQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox