public inbox for [email protected]  

help / color / mirror / Atom feed
From: Yosry Muhammad <[email protected]>
To: Dave Page <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Bug in Database Nodes in the Tree
Date: Tue, 23 Jul 2019 10:56:54 +0200
Message-ID: <CAFSMqn_dSLC1CUgPpYX3czsCwr37ZL8uvt5dOBDzk-JGD+tGnw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowEOHKTWWb59UzJ5o338OaUGwLR7+SyX0cPbb3+F2rAYg@mail.gmail.com>
References: <CAFSMqn9bUm4SGsicbVf9_vgy9rhEXp_J5zhrXM0gBgevUffrEQ@mail.gmail.com>
	<CAFOhELe=SxTy0mBMHOoKE+EfHVVDR0E_az2B7EkGvRaPQvowFQ@mail.gmail.com>
	<CAFSMqn9bkMR+qxz==9G+Q1KvQac15QTExb4WF3b8gCKxrha=rw@mail.gmail.com>
	<CA+OCxoxTCNev7Rb2ZMBN0dZOPW-jsFkOJQ0b=mjTM85ExKZSsw@mail.gmail.com>
	<CAFOhELeaibxWwOhG4_fEOSCxKKNnsOU-gQqDsxmYa98AM-FfhA@mail.gmail.com>
	<CAFSMqn9XQZULMwd3mcmN0bHhtGSzyA-YbvbprGj1EeUJhMKZKA@mail.gmail.com>
	<CAFOhELexOjuvT+2VPggw7sYP0Pa-AbA=Mp73rCWhMa2KU=34Rg@mail.gmail.com>
	<CA+OCxowEOHKTWWb59UzJ5o338OaUGwLR7+SyX0cPbb3+F2rAYg@mail.gmail.com>

Thanks for making things clear.

On Tue, Jul 23, 2019, 10:01 AM Dave Page <[email protected]> wrote:

>
>
> On Tue, Jul 23, 2019 at 4:15 AM Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> I tried just removing the lines responsible for connecting to the
>>> database on selecting a database node and it seem to work fine.
>>> Specifically the lines 254-257 in database.js (callbacks.selected function).
>>>
>>> Are there any specific scenarios I need to test to make sure everything
>>> is okay? Anywhere else in the code where I need to make changes?
>>>
>>> I think all the right side panels (i.e. Properties, SQL, etc...) will be
>> affected.
>>
>
> They're populated on select. It may mean that we have to show a "Please
> connect to the server" message in them, if a database or server is selected
> but not connected.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


view thread (9+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Bug in Database Nodes in the Tree
  In-Reply-To: <CAFSMqn_dSLC1CUgPpYX3czsCwr37ZL8uvt5dOBDzk-JGD+tGnw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox