public inbox for [email protected]help / color / mirror / Atom feed
Required inputs in issue #6138 3+ messages / 3 participants [nested] [flat]
* Required inputs in issue #6138 @ 2023-06-14 12:43 Nikhil Mohite <[email protected]> 2023-06-15 09:40 ` Re: Required inputs in issue #6138 Dave Page <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Nikhil Mohite @ 2023-06-14 12:43 UTC (permalink / raw) To: pgadmin-hackers Hi Hacker, I am currently working on issue #6138 <https://github.com/pgadmin-org/pgadmin4/issues/6138;, which was fixed earlier but the fix was not correct so working on it again. Steps to reproduce the issue: 1. Open *View/Edit Data *for *table1* 2. Open the PSQL tool delete the same *table1 *and recreates the same name table *table1* and try to re-execute the query from the already opened *View/Edit data *panel. 3. pgAdmin throws an error in the Messages tab *List index out of range *(pgAdmin query to get table columns from Postgres based on *table oid* which was deleted and the return result is empty which is not handled in pgAdmin)*.* Approach to fix this issue: 1. If the user re-executes the query from already opened *View/Edit data* we should fetch the table details by using *schema and table name (not using table oid)* and show the newly created table records in the result. (This will only fix an issue with *View/Edit Data *however if the user switches to properties or some other panel it user will still get an error notification with content *"could not find the specified table."*) -- *Thanks & Regards,* *Nikhil Mohite* *Senior Software Engineer.* *EDB Postgres* <https://www.enterprisedb.com/; *Mob.No: +91-7798364578.* ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Required inputs in issue #6138 2023-06-14 12:43 Required inputs in issue #6138 Nikhil Mohite <[email protected]> @ 2023-06-15 09:40 ` Dave Page <[email protected]> 2023-06-15 10:00 ` Re: Required inputs in issue #6138 Khushboo Vashi <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Dave Page @ 2023-06-15 09:40 UTC (permalink / raw) To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers On Wed, 14 Jun 2023 at 13:43, Nikhil Mohite <[email protected]> wrote: > Hi Hacker, > > I am currently working on issue #6138 > <https://github.com/pgadmin-org/pgadmin4/issues/6138;, which was fixed > earlier but the fix was not correct so working on it again. > Steps to reproduce the issue: > 1. Open *View/Edit Data *for *table1* > 2. Open the PSQL tool delete the same *table1 *and recreates the same > name table *table1* and try to re-execute the query from the > already opened *View/Edit data *panel. > 3. pgAdmin throws an error in the Messages tab *List index out of range *(pgAdmin > query to get table columns from Postgres based on *table oid* which was > deleted and the return result is empty which is not handled in pgAdmin)*.* > > Approach to fix this issue: > 1. If the user re-executes the query from already opened *View/Edit data* we > should fetch the table details by using *schema and table name (not using > table oid)* and show the newly created table records in the result. > (This will only fix an issue with *View/Edit Data *however if the user > switches to properties or some other panel it user will still get an error > notification with content *"could not find the specified table."*) > I think this is fine. The View/Edit data window shows the query with table/schema name after all, so the user should expect it to work. -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Required inputs in issue #6138 2023-06-14 12:43 Required inputs in issue #6138 Nikhil Mohite <[email protected]> 2023-06-15 09:40 ` Re: Required inputs in issue #6138 Dave Page <[email protected]> @ 2023-06-15 10:00 ` Khushboo Vashi <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Khushboo Vashi @ 2023-06-15 10:00 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Nikhil Mohite <[email protected]>; pgadmin-hackers On Thu, Jun 15, 2023 at 3:11 PM Dave Page <[email protected]> wrote: > > > On Wed, 14 Jun 2023 at 13:43, Nikhil Mohite < > [email protected]> wrote: > >> Hi Hacker, >> >> I am currently working on issue #6138 >> <https://github.com/pgadmin-org/pgadmin4/issues/6138;, which was fixed >> earlier but the fix was not correct so working on it again. >> Steps to reproduce the issue: >> 1. Open *View/Edit Data *for *table1* >> 2. Open the PSQL tool delete the same *table1 *and recreates the same >> name table *table1* and try to re-execute the query from the >> already opened *View/Edit data *panel. >> 3. pgAdmin throws an error in the Messages tab *List index out of range *(pgAdmin >> query to get table columns from Postgres based on *table oid* which was >> deleted and the return result is empty which is not handled in pgAdmin) >> *.* >> >> Approach to fix this issue: >> 1. If the user re-executes the query from already opened *View/Edit data* we >> should fetch the table details by using *schema and table name (not >> using table oid)* and show the newly created table records in the result. >> (This will only fix an issue with *View/Edit Data *however if the user >> switches to properties or some other panel it user will still get an error >> notification with content *"could not find the specified table."*) >> > > I think this is fine. The View/Edit data window shows the query with > table/schema name after all, so the user should expect it to work. > > The object for which the user has opened the View data panel is completely changed. So as per me, it should raise the error object doesn't exist. The table name is the same, but it is a different object, and when we initialise the panel, we consider that object. -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-06-15 10:00 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-06-14 12:43 Required inputs in issue #6138 Nikhil Mohite <[email protected]> 2023-06-15 09:40 ` Dave Page <[email protected]> 2023-06-15 10:00 ` Khushboo Vashi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox