public inbox for [email protected]
help / color / mirror / Atom feedFrom: Matthew Kleiman <[email protected]>
To: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Shruti B Iyer <[email protected]>
Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React
Date: Thu, 18 May 2017 15:37:07 +0000
Message-ID: <CAFS4TJapVubRP_BK01GwYjfN7zpaTbCMX+CROC4mV93aL08DOg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxow3e=q9w_e=Kkw1ebZJ82EM8RyFmiTaXihdqhX6HbzZhw@mail.gmail.com>
References: <CAFS4TJYDRi6fs+wrhkj89gFe3xaFOkoApCK+AU2O4DfU2XfXog@mail.gmail.com>
<CAKKotZQSTtJVkBKMeFi9vTrPugBEbEE38dhbbn-hr+hpd0Qzbw@mail.gmail.com>
<CA+OCxowChMtZzaSwrG5Sganh4LiMQcgL7BpoqhTxZga30DqDXw@mail.gmail.com>
<CAKKotZRmvbScMdUtjMgUJdRe-EXaqDoDbYBxrMZrkbVDVR_iUg@mail.gmail.com>
<CA+OCxow3e=q9w_e=Kkw1ebZJ82EM8RyFmiTaXihdqhX6HbzZhw@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Dave,
Can you try running grunt tests on the command line?
The tests task will run the eslint and karma grunt tasks, which should
automatically webpack the React components before running the jasmine tests
in karma.
If it still fails, send us the output of that.
Thanks,
Matt
On Thu, May 18, 2017 at 5:31 AM Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, May 18, 2017 at 9:56 AM, Murtuza Zabuawala <
> [email protected]> wrote:
>
>>
>> Go to 'pgadmin4/web' directory
>>
>> Try running,
>>
>> run 'yarn install'
>>
>> (if you have installed globally)
>> then run 'grunt'
>> OR
>> run './node_modules/grunt-cli/bin/grunt'
>>
>>
>> Then run pgAdmin4
>>
>
> OK, that worked - though pgAdmin now takes a lot longer to start up, which
> is a problem.
>
> The Jasmine tests now fail:
>
> (pgadmin4)piranha:web dpage$ yarn run karma start --single-run
> yarn run v0.24.4
> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/karma" start
> 18 05 2017 10:22:01.182:ERROR [plugin]: Error during loading
> "karma-phantomjs-launcher" plugin:
> Path must be a string. Received null
>
> webpack: Compiled successfully.
> webpack: Compiling...
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> (node:12214) DeprecationWarning: loaderUtils.parseQuery() received a
> non-string value which can be problematic, see
> https://github.com/webpack/loader-utils/issues/56
> parseQuery() will be replaced with getOptions() in the next major version
> of loader-utils.
> 18 05 2017 10:22:07.281:WARN [karma]: No captured browser, open
> http://localhost:9876/
>
> webpack: Compiled successfully.
> 18 05 2017 10:22:07.294:ERROR [karma]: Found 1 load error
> error Command failed with exit code 1.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> this command.
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
view thread (45+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React
In-Reply-To: <CAFS4TJapVubRP_BK01GwYjfN7zpaTbCMX+CROC4mV93aL08DOg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox