public inbox for [email protected]
help / color / mirror / Atom feedFrom: Harshal Dhumal <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Fix for issue RM1336 [pgadmin4]
Date: Thu, 30 Jun 2016 00:02:15 +0530
Message-ID: <CAFiP3vxp-Y0OYuDMYR7Fbe9g3j5EKSxvSk=iz3MmXeSjsSs+hw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowF=XkYmrv4uggjW=rWDyS71+ZFhf-sdB-+5beU0_o=jQ@mail.gmail.com>
References: <CAFiP3vxoqJ8Rd2fiXev2di1Se_WuyAZdMtUHcHG3HuHwk-vj0g@mail.gmail.com>
<CA+OCxozZz4q4Cac8sS2wZ0OprfjOKQRqmSXQjHdd=-sBoVfsbA@mail.gmail.com>
<CAFiP3vxfQ4=+zjLW9HR_dtYkbgfZLvKLnLZi-A3m4rbFH_A5xA@mail.gmail.com>
<CAFiP3vznYPXdvmGj2J7i4S7e-BPUVWWUC5KFAK=Q7n6Nee5ThA@mail.gmail.com>
<CA+OCxoza3djrtauF1VqSvqU1pXBr8gAzHD9xF1T37HbkbgEztA@mail.gmail.com>
<CAFiP3vyTB+ceHGxwXn_w8RBmDQn9SVC3i+1kXhv=CD8UWr3=Xg@mail.gmail.com>
<CA+OCxowGax9fd5YmTG3u82Ums0rwkETiXFQPuBokKBx_Br8BOA@mail.gmail.com>
<CAG7mmozksaXEZv=Sz-f4vkHgDjn-_5LTBzP5=wP-+RNeCMVH3Q@mail.gmail.com>
<CA+OCxoy=cO2feBinWxO8hMuUN3x9+DFeKkDZ-5hv=2NWfht-dw@mail.gmail.com>
<CAFiP3vxq4-jHf0GALVH=eaQM5d+rrdu8Z49Q1ksL4ftKUzzVyQ@mail.gmail.com>
<CA+OCxowSS8R1zh1jajhhN6ibtH4x1+w=xwY5i11_Ub7zCJ9JFQ@mail.gmail.com>
<CAMjNa7e3vkEsiRGqt6kw3Z+z6v-z6Ox4-F0VmCDJEGW2pynWOg@mail.gmail.com>
<CA+OCxoxbbVX6HZJVeXxRFhbkiG692RZx9WoWo=jmkv6gc79eRA@mail.gmail.com>
<[email protected]>
<CA+OCxowW1+ezv93fdbvKtmper+jWOfs+XbgdCSMUJiH23xHQAA@mail.gmail.com>
<CAFiP3vywwsR96uwDd-KzwF1Vc3DEaBnKWT5v4Sc6y3f-FstCGQ@mail.gmail.com>
<CA+OCxowF=XkYmrv4uggjW=rWDyS71+ZFhf-sdB-+5beU0_o=jQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi,
Here is updated patch for RM1336
Fixed query tool shortcuts issue in Mac runtime and changed shortcut to
show "About" dialog in runtime from Ctrl+Shift+A ----> Alt+Shift+A
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Jun 29, 2016 at 11:41 PM, Dave Page <[email protected]> wrote:
> Hi
>
> On Wed, Jun 29, 2016 at 7:05 PM, Harshal Dhumal
> <[email protected]> wrote:
> > Hi,
> >
> > PFA upadated patch for RM1336
> >
> > Issue fixed: Query tool shortcuts weren't working on mac runtime. Also
> > changed shortcut key for "Explain analyze" from Ctrl+Shift+A --->
> > Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about"
> > dialog in runtime.
>
> Thanks - but let's change the runtime and go back to Ctrl+Shift+A in
> the app. The About box in the runtime is really unimportant.
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[text/x-patch] RM1336_V3.patch (1.5K, 3-RM1336_V3.patch)
download | inline diff:
diff --git a/runtime/BrowserWindow.cpp b/runtime/BrowserWindow.cpp
index 5419c0e..684cb27 100644
--- a/runtime/BrowserWindow.cpp
+++ b/runtime/BrowserWindow.cpp
@@ -125,7 +125,7 @@ void BrowserWindow::createActions()
connect(exitShortcut, SIGNAL(activated()), this, SLOT(close()));
// About box
- aboutShortcut = new QShortcut(QKeySequence(Qt::CTRL + Qt::SHIFT + Qt::Key_A), this);
+ aboutShortcut = new QShortcut(QKeySequence(Qt::ALT + Qt::SHIFT + Qt::Key_A), this);
aboutShortcut->setContext(Qt::ApplicationShortcut);
connect(aboutShortcut, SIGNAL(activated()), this, SLOT(about()));
}
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 92579f1..2a269c0 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -176,7 +176,7 @@ define(
"click #btn-explain-buffers": "on_explain_buffers",
"click #btn-explain-timing": "on_explain_timing",
"change .limit": "on_limit_change",
- "keyup": "keyAction"
+ "keydown": "keyAction"
},
// This function is used to render the template.
@@ -1020,7 +1020,7 @@ define(
// char e/E
// Execute query.
this.on_flash(ev);
- } else if(ev.keyCode == 88){
+ } else if(ev.keyCode == 88) {
// char x/X
// Explain query.
this.on_explain(ev);
view thread (26+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Fix for issue RM1336 [pgadmin4]
In-Reply-To: <CAFiP3vxp-Y0OYuDMYR7Fbe9g3j5EKSxvSk=iz3MmXeSjsSs+hw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox