public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ashesh Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: John Obaterspok <[email protected]>
Cc: Sanket Mehta <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2
Date: Fri, 25 Sep 2015 13:30:44 +0530
Message-ID: <CAG7mmoxkdFxz-gqZsf1zo8GRqTgbmpSjU0DJ8=L7Y6rkfdxaQg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoy6H_MVA5wbaLbLgyLico0K-vhJvVLjozD4MWV-AVcOhQ@mail.gmail.com>
References: <CAOscVdK0zqXa8N179ug0MZ3SqQQDsfXaqPSvsa4As2Mx4xR1KA@mail.gmail.com>
<CAG7mmoyScrFdXCY7apkS67S=j3ciQF7=+YX6QENb_rQ0q8ztuQ@mail.gmail.com>
<CA+yw=mPcHKuLwAwKU6qFa_v1mo=OBU_=g_x71vdDB1oK4_BMcg@mail.gmail.com>
<CA+yw=mNFpBWqPYB+_S-L34MbH-MqudY3KiduK7p+cLs4aLB1Bw@mail.gmail.com>
<CAOscVdKfDJJYM1nQeXQ=6NO5ySyz7E4750gNe+-GbfX2nT_YEQ@mail.gmail.com>
<CAOscVdLSYUrYZr9kGffOfj=UmxDm=nuvgySVnhBt5oW4G71K0w@mail.gmail.com>
<CA+yw=mO-nYpM6_fNz+cqMjQiq2hNuE31yV_w+3o7QTNiqV2NPg@mail.gmail.com>
<CAOscVd+mBHQqkLwUW1Ju3PoVwDv6yfO4TwRdh2pEDTjjfUt-MA@mail.gmail.com>
<CA+OCxoy6H_MVA5wbaLbLgyLico0K-vhJvVLjozD4MWV-AVcOhQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Yup.
It's in my plate, was updating the CHANGELOG only.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
On Fri, Sep 25, 2015 at 1:28 PM, Dave Page <[email protected]> wrote:
> Ashesh, are you able to deal with this before Monday (when I'll be cutting
> the feature-frozen beta 1 tarballs)?
>
> On Fri, Sep 25, 2015 at 7:03 AM, John Obaterspok <
> [email protected]> wrote:
>
>> Thanks, appreciated.
>>
>> Can it be committed then? :)
>>
>> 2015-09-23 9:49 GMT+02:00 Sanket Mehta <[email protected]>:
>>
>>> Hi John/Ashesh,
>>>
>>> I have reviewed the patch and it seems fine to me.
>>>
>>> Regards,
>>> Sanket Mehta
>>> Sr Software engineer
>>> Enterprisedb
>>>
>>> On Wed, Sep 23, 2015 at 11:08 AM, John Obaterspok <
>>> [email protected]> wrote:
>>>
>>>> Hi Sanket,
>>>>
>>>> Did you give the patch a try? I would really like it to for the next
>>>> release :)
>>>>
>>>> -- john
>>>>
>>>> 2015-09-16 20:27 GMT+02:00 John Obaterspok <[email protected]>:
>>>>
>>>>> Hi Sanket,
>>>>>
>>>>> Attached patch is rebased now.
>>>>>
>>>>> Regards,
>>>>>
>>>>> -- john
>>>>>
>>>>>
>>>>> 2015-09-16 11:20 GMT+02:00 Sanket Mehta <[email protected]
>>>>> >:
>>>>>
>>>>>> Hi John,
>>>>>>
>>>>>> Patch is not proper.
>>>>>> I got below error when I try to apply the patch:
>>>>>>
>>>>>> error: patch failed: pgadmin/frm/frmQuery.cpp:2435
>>>>>> error: pgadmin/frm/frmQuery.cpp: patch does not apply
>>>>>>
>>>>>> Please do provide the proper patch.
>>>>>>
>>>>>>
>>>>>> Regards,
>>>>>> Sanket Mehta
>>>>>> Sr Software engineer
>>>>>> Enterprisedb
>>>>>>
>>>>>> On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Sure Ashesh,
>>>>>>>
>>>>>>> I will review the patch.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Sanket Mehta
>>>>>>> Sr Software engineer
>>>>>>> Enterprisedb
>>>>>>>
>>>>>>> On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Sanket,
>>>>>>>>
>>>>>>>> Can you please take a look at it?
>>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>> Thanks & Regards,
>>>>>>>>
>>>>>>>> Ashesh Vashi
>>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>>>> <http://www.enterprisedb.com;
>>>>>>>>
>>>>>>>>
>>>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>>>>
>>>>>>>> On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> I'm updated the patch to add commit/rollback actions in the
>>>>>>>>> toolbar with the following:
>>>>>>>>> 1) updated icons (based on existing pgadmin icon with arrows drawn
>>>>>>>>> by me)
>>>>>>>>> 2) add entry to menu as well
>>>>>>>>> 3) disable icons when not in a transaction
>>>>>>>>> 4) Ctrl+Shift C|R shortcut
>>>>>>>>>
>>>>>>>>> Hopefully all issues are resolved now!
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>>
>>>>>>>>> John
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Sent via pgadmin-hackers mailing list (
>>>>>>>>> [email protected])
>>>>>>>>> To make changes to your subscription:
>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2
In-Reply-To: <CAG7mmoxkdFxz-gqZsf1zo8GRqTgbmpSjU0DJ8=L7Y6rkfdxaQg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox