public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ashesh Vashi <[email protected]>
To: Surinder Kumar <[email protected]>
To: Arun Kollan <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
Date: Fri, 29 Apr 2016 16:06:49 +0530
Message-ID: <CAG7mmozwV51hVVPpNx5A6Q184bMvvdbE-iC6FSO-A1oL2J6iEw@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D8hpNUTdYG_xqTLw7YxjynnNLM+niEgOd3gOab0G3Ry6g@mail.gmail.com>
References: <CAM5-9D8tCizz9o7EDDr_Xyur8Wh2HX1rs5drEycAKmsXBtE+1A@mail.gmail.com>
	<CAM5-9D8hpNUTdYG_xqTLw7YxjynnNLM+niEgOd3gOab0G3Ry6g@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks - committed!

Thanks Arun for the quick review!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;

On Fri, Apr 29, 2016 at 11:34 AM, Surinder Kumar <
[email protected]> wrote:

> Hi,
>
> More specifically to the issue.
> I am using SqlFieldControl in View for Definition Field which takes
> default height of 300px which is set by Control as default height. but as
> per dave's suggestion on thread
>
>
> http://www.postgresql.org/message-id/[email protected]....
>
> "The Definition box on the View dialogue should start at a single
> line and expand as needed - see the Function dialogue".
>
> If user still need some height for control, It can be specified in*
> extraclasses[]* parameter which will apply to the specific field.
>
>
>
> On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <
> [email protected]> wrote:
>
>> Hi,
>>
>> The *SqlFieldControl* is setting default height for textarea, which is
>> not needed.
>> It should expand as needed as similar in *SqlTabControl*.
>>
>> Please find the attached patch, review it.
>>
>> Thanks
>> Surinder Kumar
>>
>
>

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
  In-Reply-To: <CAG7mmozwV51hVVPpNx5A6Q184bMvvdbE-iC6FSO-A1oL2J6iEw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox