public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
Date: Thu, 28 Apr 2016 19:02:07 +0530
Message-ID: <CAM5-9D8tCizz9o7EDDr_Xyur8Wh2HX1rs5drEycAKmsXBtE+1A@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

The *SqlFieldControl* is setting default height for textarea, which is not
needed.
It should expand as needed as similar in *SqlTabControl*.

Please find the attached patch, review it.

Thanks
Surinder Kumar


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] remove_default_height_in_SqlFieldControl.patch (489B, 3-remove_default_height_in_SqlFieldControl.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 544d574..ec7ecf4 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1905,7 +1905,7 @@
 
     defaults: {
       label: "",
-      extraClasses: ['sql_field_height_300'], // Add default control height
+      extraClasses: [], // Add default control height
       helpMessage: null,
       maxlength: 4096,
       rows: undefined

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
  In-Reply-To: <CAM5-9D8tCizz9o7EDDr_Xyur8Wh2HX1rs5drEycAKmsXBtE+1A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox