public inbox for [email protected]
help / color / mirror / Atom feedFrom: Sarah McAlear <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: Robert Eckhardt <[email protected]>
Cc: Joao Pedro De Almeida Pereira <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Matthew Kleiman <[email protected]>
Subject: Re: [patch] Dependents and Dependencies in GreenPlum
Date: Wed, 10 May 2017 09:37:21 -0400
Message-ID: <CAGRPzo95Yy4u-CQHFXXX=49Thci3mgdMvm3hxuJKNc0MhZU8tg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfeJOiFKpsNa6aWU0Kui_3Pz6nswW=8uUE==8FUYJ3WoQ@mail.gmail.com>
References: <CAE+jjam5JoMt9+Ue-O_qpgEJO_wAGJfGoaLCJg-1VzVc+AqB_w@mail.gmail.com>
<CA+OCxoxOaYKi6j5dwgwEP7VtP-8XDiee101kjnO3e6SJc4Mp1g@mail.gmail.com>
<CAG7mmoyg2nbVHtYJVd1RA4e2orMv6nsaPoSbUeupy9akrz-z_w@mail.gmail.com>
<CAE+jja=8s-x82BVuBD4THq5V=07F_rJn0+Sa8vUGc=rOtxwWLA@mail.gmail.com>
<CAE+jja=dpFAAxavzJupBjcKQNZjox+grCiqd53AC2EO2G-FGdg@mail.gmail.com>
<CAGRPzo-pSDrQwXOHcy1aPbe==nNqRQpJeK6h2qr8_rsGiidRHg@mail.gmail.com>
<CAAtBm9V77+cbV5fbOkwrPg6JNDuVxQq5=ug7vdChAuTDY0Wj8Q@mail.gmail.com>
<CA+OCxozvcTmYOBrdXMi=b3w4f3LaBSYUMyJiTaUhz-uLuOAWiA@mail.gmail.com>
<CA+OCxozwGCNHJ1d58Huoc=zWGkvH3yWhrzRE9kE7oKm-LdQdYQ@mail.gmail.com>
<CANxoLDfcwCnw8ZRaVzT8TO4be1tmT1XSfOUrD=zMiud-cHLybA@mail.gmail.com>
<CANxoLDfGtTEyfwb=2snvRYN5qAr_CiC5s4J-_NMeSY8hUk8M7A@mail.gmail.com>
<CA+OCxoySRBh0YRRxOo-Osn3WOViPkcO-2Qt55iBjByzEb=bhtQ@mail.gmail.com>
<CAGRPzo9rkT+ehf-ShMvzU_TGyXT5eCek=jQDeSk5pnaMoQgzuQ@mail.gmail.com>
<CANxoLDc-j1rVx4Ke+Qjxpi82Nj4FfbhiYhriVY3ekNbtKBF2qQ@mail.gmail.com>
<CAGRPzo_ATD7Erwz=5Eay1GDfXnDq4DvEinYvfsSGQbVBmcxrNg@mail.gmail.com>
<CANxoLDfeJOiFKpsNa6aWU0Kui_3Pz6nswW=8uUE==8FUYJ3WoQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Akshay!
Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tests
pass.
Thanks!
João & Sarah
On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi <[email protected]
> wrote:
> Hi Sarah
>
> On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear <[email protected]> wrote:
>
>> Hi Akshay!
>>
>>
>>> Some test file names ended with "*_sql_template.py*" do we need to add
>>> that string ?
>>
>> we added this suffix after moving the tests up a level to tables/tests to
>> clarify what subject they applied to. we changed the suffix to "_sql.py"
>>
>> - Files "test_column_acl_sql_template.py" and "test_column_properties_sql
>>> _template.py" should be moved from tables->tests to
>>> tables->column->tests. As it's related to column.
>>> - Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_
>>> sql_template.py" should be moved from tables->tests to
>>> tables->triggers->tests. As its related to triggers.
>>
>> these tests are related to the sql files in tables/templates/column, not
>> tables/column, so moving them into tables/column would be more confusing.
>>
>> Following test cases are failing
>>
>> Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql
>> doesn't fail in your environment?
>>
>
> TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed
> with below error:
> .....\test_role_dependencies_sql.py\", line 41, in assertions\n
> self.assertEqual(1, len(fetch_result))\nAssertionError: 1 != 0
>
>
>> Thanks,
>> George & Sarah
>>
>>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>
view thread (27+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [patch] Dependents and Dependencies in GreenPlum
In-Reply-To: <CAGRPzo95Yy4u-CQHFXXX=49Thci3mgdMvm3hxuJKNc0MhZU8tg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox