public inbox for [email protected]
help / color / mirror / Atom feedFrom: Chethana Kumar <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4[RM#3948] Fix backform note control style
Date: Fri, 1 Feb 2019 18:53:03 +0530
Message-ID: <CAH4-4WtwHzY+QmCb6f9Dwy+S1qXgRj5J=JNSXUHnY5JxuWR+yg@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmoxtx+fZDs3SqJhwjzn1T_T7vpLZAqzoPX3k4T2MTqUfYg@mail.gmail.com>
References: <CAKKotZQ_05r3Az6pJYjs60PC+ARswhHz=sEZPnUfST7gfDaqtA@mail.gmail.com>
<CAFOhELcqqKvPGYk=NSV0hpN+iBut_g1B_Azk2c_Hoe-fRerLtg@mail.gmail.com>
<CAH4-4Wva29DXX0W-Cr5qaOvZrZAsWOiUqsmV0i+AWsEwfBr-WA@mail.gmail.com>
<CAG7mmoxtx+fZDs3SqJhwjzn1T_T7vpLZAqzoPX3k4T2MTqUfYg@mail.gmail.com>
Ashesh,
It remains same with the white background because the note icon itself
enough to grab the attention of the user.
I have attached the design sample as well.
[image: with-patch.png]
---
Chethana kumar
On Fri, Feb 1, 2019 at 6:45 PM Ashesh Vashi <[email protected]>
wrote:
> On Fri, Feb 1, 2019 at 6:42 PM Chethana Kumar <
> [email protected]> wrote:
>
>> Hi Khushboo and Murtuza,
>>
>> I have attached the improved version of the design, please share your
>> views.
>> A '*note*' text should be always be highlighted rather than keeping it
>> muted (faded coloured text).
>>
> Chethana,
>
> Can you please send the color combination, when the note control is
> appeared under a subnode control (with white background color)?
>
> -- Thanks, Ashesh
>
>>
>> ---
>> Chethana kumar
>> [image: Existing_design.png]
>>
>>
>>
>> On Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi Murtuza,
>>>
>>> I have reviewed your patch and I feel we need Chethana's suggestion on
>>> this.
>>>
>>> @ Chethana,
>>>
>>> Please have a look the attached screen-shots (Existing_design and
>>> Proposed_design). With this patch the *Note* section design has been
>>> changed.
>>> We need your suggestion on this to improve it as I feel it needs
>>> improvement.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>
>>> On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA minor patch to fix the style, changed the background colour and
>>>> text colour so that it can be readable.
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>
>> --
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146
>> www.enterprisedb.com
>>
>
--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
The Postgres Database Company
P: +91 86981 57146
www.enterprisedb.com
Attachments:
[image/png] Existing_design.png (392.8K, 3-Existing_design.png)
download | view image
[image/png] with-patch.png (292.1K, 4-with-patch.png)
download | view image
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4[RM#3948] Fix backform note control style
In-Reply-To: <CAH4-4WtwHzY+QmCb6f9Dwy+S1qXgRj5J=JNSXUHnY5JxuWR+yg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox