public inbox for [email protected]  

help / color / mirror / Atom feed

javascript and css minification process
3+ messages / 2 participants
[nested] [flat]

* javascript and css minification process
@ 2017-05-12 14:29  George Gelashvili <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: George Gelashvili @ 2017-05-12 14:29 UTC (permalink / raw)
  To: pgadmin-hackers; +Cc: Dave Page <[email protected]>

Hello

We're looking at the js and css minimization python code to investigate
minification as part of the pgadmin artifact build process.

We're wondering why minimise.py is currently only manually invokable, via
the minimise make step.

Also it seems like currently, minimise.py's dependencies (rcssmin and
rjsmin) are not being included in any requirements.txt

When is the minification performed?

Thanks,
Joao and George


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: javascript and css minification process
@ 2017-05-12 14:37  Dave Page <[email protected]>
  parent: George Gelashvili <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Dave Page @ 2017-05-12 14:37 UTC (permalink / raw)
  To: George Gelashvili <[email protected]>; +Cc: pgadmin-hackers

Hi

On Fri, May 12, 2017 at 3:29 PM, George Gelashvili <[email protected]>
wrote:

> Hello
>
> We're looking at the js and css minimization python code to investigate
> minification as part of the pgadmin artifact build process.
>
> We're wondering why minimise.py is currently only manually invokable, via
> the minimise make step.
>
> Also it seems like currently, minimise.py's dependencies (rcssmin and
> rjsmin) are not being included in any requirements.txt
>
> When is the minification performed?
>

It's not yet. Those are utility scripts that I was eventually intending to
call from appropriate make targets during package build. Before we get
there though, we need code changes to ensure that we load minified code vs.
debug code at the appropriate times. I haven't done much with it in a while
as Tira had been talking about transpiling everything into a single blob
(though that required us to ensure none of the JS files were Jinja
templates any more).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: javascript and css minification process
@ 2017-05-12 14:54  George Gelashvili <[email protected]>
  parent: Dave Page <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: George Gelashvili @ 2017-05-12 14:54 UTC (permalink / raw)
  To: Dave Page <[email protected]>; +Cc: pgadmin-hackers

>
> It's not yet. Those are utility scripts that I was eventually intending to
> call from appropriate make targets during package build. Before we get
> there though, we need code changes to ensure that we load minified code vs.
> debug code at the appropriate times. I haven't done much with it in a while
> as Tira had been talking about transpiling everything into a single blob
> (though that required us to ensure none of the JS files were Jinja
> templates any more).
>

Okay. We are thinking of using a javascript minification tool and run it as
part of the bundling process.
We are using grunt to bundle everything (such as react code and
dependencies). Other javascript and css files can be added to the bundling
process as we all see fit.


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

end of thread, other threads:[~2017-05-12 14:54 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12 14:29 javascript and css minification process George Gelashvili <[email protected]>
2017-05-12 14:37 ` Dave Page <[email protected]>
2017-05-12 14:54   ` George Gelashvili <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox