public inbox for [email protected]
help / color / mirror / Atom feedFrom: Pradip Parkale <[email protected]>
To: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify
Date: Tue, 25 Feb 2020 15:32:03 +0530
Message-ID: <CAJ9T6SuA5a0pYGMduuvpZnqXfvKmaOC45v9jc-mZm1DQ8bH=sA@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_n9oO0Dz5sVb+wHkqbmzsS8gZdG-DJ7h9DELgoa9kk42A@mail.gmail.com>
References: <CAJ9T6SsEuKBVz35pA0X+G7u6Z0JcV8ZAHB46kRD1PiovmJrhpg@mail.gmail.com>
<CAG7mmoy5TCYNYPcD31FG=-jHzRJG7pdiNrFVXsFnVNKY+Qp8VQ@mail.gmail.com>
<CAJ9T6Su8cJBL4khVrE1h4U8d0EAyiadLyseFaoKEtJ6-tJ_rgA@mail.gmail.com>
<CANxoLDeefWqrFZHSyTE4Ugh2Dity0cUwoHNaMZemtRnqt-pfEA@mail.gmail.com>
<CAM9w-_n9oO0Dz5sVb+wHkqbmzsS8gZdG-DJ7h9DELgoa9kk42A@mail.gmail.com>
Hi Akshay/Aditya,
Please find the updated patch. I have accommodated all the changes.
On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Pradip,
>
> -
> commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content
> div.active'));
> +
> $(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus();
>
> Use the same common function with
> commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)). It will
> handle the focus.
>
Fixed.
> Also, make the required changes mentioned on the pull request -
> https://github.com/EnterpriseDB/AlertifyJS/pull/1
>
Fixed.
>
>
> On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Aditya
>>
>> Can you please review this patch.
>>
>> On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale <
>> [email protected]> wrote:
>>
>>> Please find the attached patch.
>>>
>>> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi <
>>> [email protected]> wrote:
>>>
>>>> Forgot to attach the patch?
>>>>
>>>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is a patch for accessibility issue related Alertifyjs.
>>>>>
>>>>> 1. Added hidden label to satisfy accessibility.
>>>>> 2. Added label with sr-only class.
>>>>> 3. Added tabindex to move the mouse control to the maximize button
>>>>> using the tab key.
>>>>>
>>>>>
>>>>> Please note that this patch also includes the fix for the
>>>>> RM-5143 Accessibility issue to maximize the panel for backup and restore
>>>>> windows and all other places.
>>>>> --
>>>>> Thanks & Regards,
>>>>> Pradip Parkale
>>>>> QMG, EnterpriseDB Corporation
>>>>>
>>>> --
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>> <http://www.enterprisedb.com;
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*
>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> QMG, EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation
Attachments:
[application/octet-stream] RM5154_v2.patch (2.5K, 3-RM5154_v2.patch)
download | inline diff:
diff --git a/web/package.json b/web/package.json
index acfcb2efa..ba92e291b 100644
--- a/web/package.json
+++ b/web/package.json
@@ -51,7 +51,7 @@
},
"dependencies": {
"acitree": "git+https://github.com/imsurinder90/jquery-aciTree.git#rc.7",
- "alertifyjs": "1.7.1",
+ "alertifyjs": "git+https://github.com/EnterpriseDB/AlertifyJS/#72c1d794f5b6d4ec13a68d123c08f19021afe263",
"axios": "^0.18.1",
"babel-plugin-transform-es2015-modules-amd": "^6.24.1",
"babel-preset-es2015-without-strict": "~0.0.4",
diff --git a/web/pgadmin/static/js/alertify/dialog_wrapper.js b/web/pgadmin/static/js/alertify/dialog_wrapper.js
index 83186e710..5346b6a0d 100644
--- a/web/pgadmin/static/js/alertify/dialog_wrapper.js
+++ b/web/pgadmin/static/js/alertify/dialog_wrapper.js
@@ -64,7 +64,7 @@ export class DialogWrapper {
$(alertifyDialog.elements.footer).on('keydown', 'button', function(event) {
if (event.keyCode == 9 && $(this).nextAll('button:not([disabled])').length == 0) {
// set focus back to first editable input element of current active tab once we cycle through all enabled buttons.
- commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content div.active'));
+ commonUtils.findAndSetFocus($(alertifyDialog.elements.dialog));
return false;
}
});
diff --git a/web/pgadmin/static/js/utils.js b/web/pgadmin/static/js/utils.js
index 9f9ef32c7..86dae698e 100644
--- a/web/pgadmin/static/js/utils.js
+++ b/web/pgadmin/static/js/utils.js
@@ -37,6 +37,7 @@ export function findAndSetFocus(container) {
.find(`
.pgadmin-controls:first input:enabled,
.pgadmin-controls:first .btn:not(.toggle),
+ .ajs-commands:first,
.CodeMirror-scroll`)
.find('*[tabindex]:not([tabindex="-1"])');
}
diff --git a/web/yarn.lock b/web/yarn.lock
index 26272668b..51334ccee 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -910,10 +910,9 @@ ajv@^6.1.0, ajv@^6.10.2, ajv@^6.9.1:
json-schema-traverse "^0.4.1"
uri-js "^4.2.2"
[email protected]:
+"alertifyjs@git+https://github.com/EnterpriseDB/AlertifyJS/#72c1d794f5b6d4ec13a68d123c08f19021afe263":
version "1.7.1"
- resolved "https://registry.yarnpkg.com/alertifyjs/-/alertifyjs-1.7.1.tgz#3c7b8ac67609aea737fe8e06d7fac885ce18ba8f"
- integrity sha1-PHuKxnYJrqc3/o4G1/rIhc4Yuo8=
+ resolved "git+https://github.com/EnterpriseDB/AlertifyJS/#72c1d794f5b6d4ec13a68d123c08f19021afe263"
alphanum-sort@^1.0.0:
version "1.0.2"
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify
In-Reply-To: <CAJ9T6SuA5a0pYGMduuvpZnqXfvKmaOC45v9jc-mZm1DQ8bH=sA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox