public inbox for [email protected]help / color / mirror / Atom feed
[Accessibility] RM4608 Few issues in the dialogs. 4+ messages / 2 participants [nested] [flat]
* [Accessibility] RM4608 Few issues in the dialogs. @ 2020-03-19 08:56 Pradip Parkale <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Pradip Parkale @ 2020-03-19 08:56 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Please find the patch for accessibility errors in some of the dialogs. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation Attachments: [application/octet-stream] RM4608.patch (8.6K, 3-RM4608.patch) download | inline diff: diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js index b38ee2cab..ab4838ea5 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js @@ -212,7 +212,7 @@ define('pgadmin.node.fts_configuration', [ ' </div>', ' <div class="col-6" header="token"></div>', ' <div class="col-2">', - ' <button class="btn btn-sm-sq btn-secondary add fa fa-plus" <%=canAdd ? "" : "disabled=\'disabled\'"%> ></button>', + ' <button class="btn btn-sm-sq btn-secondary add fa fa-plus" <%=canAdd ? "" : "disabled=\'disabled\'"%> ><span class="sr-only">Add Token</span></button>', ' </div>', ' </div>', ' </div>', diff --git a/web/pgadmin/browser/server_groups/servers/templates/servers/password.html b/web/pgadmin/browser/server_groups/servers/templates/servers/password.html index a41b3f0b1..afdfbfe96 100644 --- a/web/pgadmin/browser/server_groups/servers/templates/servers/password.html +++ b/web/pgadmin/browser/server_groups/servers/templates/servers/password.html @@ -1,9 +1,9 @@ <form name="frmPassword" id="frmPassword" style="height: 100%; width: 100%" onsubmit="return false;"> <div> - <div><label class="font-weight-bold" for="password">{{ _('Please enter the password for the user \'{0}\' to connect the server - "{1}"').format(username, - server_label) }}</label></div> + <div><span class="font-weight-bold" >{{ _('Please enter the password for the user \'{0}\' to connect the server - "{1}"').format(username, + server_label) }}</span></div> <div class="input-group row py-2"> - <span class="col-sm-2 col-form-label" aria-hidden="true">Password</span> + <label for="password" class="col-sm-2 col-form-label" aria-hidden="true">Password</label> <div class="col-sm-10"> <input id="password" class="form-control" name="password" type="password"> </div> diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js index a1c898890..a44d1a83a 100644 --- a/web/pgadmin/static/js/backform.pgadmin.js +++ b/web/pgadmin/static/js/backform.pgadmin.js @@ -1581,7 +1581,7 @@ define([ showGridControl: function(data) { var self = this, gridHeader = ['<div class=\'subnode-header\'>', - ' <label class=\'control-label pg-el-sm-10\'>' + data.label + '</label>', + ' <span class=\'control-label pg-el-sm-10\'>' + data.label + '</span>', ' <button aria-label="' + _('Add') + '" class=\'btn btn-sm-sq btn-secondary add fa fa-plus\' title=\'' + _('Add new row') + '\'></button>', '</div>', ].join('\n'), @@ -2890,41 +2890,40 @@ define([ }, down: function() { + let $el = this.$el.find('.datetimepicker-input'); + let currdate = $el.data('datetimepicker').date().clone(); if (this.$el.find('.datepicker').is(':visible')) { - let $el = this.$el.find('.datetimepicker-input'); - let currdate = $el.data('datetimepicker').date().clone(); $el.datetimepicker('date', currdate.add(7, 'd')); } else { - let $el = this.$el.find('.datetimepicker-input'); - let currdate = $el.data('datetimepicker').date().clone(); $el.datetimepicker('date', currdate.subtract(1, 'm')); } }, up: function() { + let $el = this.$el.find('.datetimepicker-input'); + let currdate = $el.data('datetimepicker').date().clone(); + if (this.$el.find('.datepicker').is(':visible')) { - let $el = this.$el.find('.datetimepicker-input'); - let currdate = $el.data('datetimepicker').date().clone(); $el.datetimepicker('date', currdate.subtract(7, 'd')); } else { - let $el = this.$el.find('.datetimepicker-input'); - let currdate = $el.data('datetimepicker').date().clone(); $el.datetimepicker('date', currdate.add(1, 'm')); } }, left: function() { + let $el = this.$el.find('.datetimepicker-input'); + let currdate = $el.data('datetimepicker').date().clone(); + if (this.$el.find('.datepicker').is(':visible')) { - let $el = this.$el.find('.datetimepicker-input'); - let currdate = $el.data('datetimepicker').date().clone(); $el.datetimepicker('date', currdate.subtract(1, 'd')); } }, right: function() { + let $el = this.$el.find('.datetimepicker-input'); + let currdate = $el.data('datetimepicker').date().clone(); + if (this.$el.find('.datepicker').is(':visible')) { - let $el = this.$el.find('.datetimepicker-input'); - let currdate = $el.data('datetimepicker').date().clone(); $el.datetimepicker('date', currdate.add(1, 'd')); } }, @@ -3193,7 +3192,7 @@ define([ template: _.template([ '<label class="<%=Backform.controlLabelClassName%> keyboard-shortcut-label"><%=label%></label>', '<div class="<%=Backform.controlsClassName%>">', - ' <input type="<%=type%>" class="<%=Backform.controlClassName%> <%=extraClasses.join(\' \')%>" name="<%=name%>" oncopy="return false; oncut="return false; onpaste="return false;" maxlength="<%=maxlength%>" value="<%-value%>" placeholder="<%-placeholder%>" <%=disabled ? "disabled" : ""%> <%=required ? "required" : ""%> />', + ' <input aria-label="<%=name%>" type="<%=type%>" class="<%=Backform.controlClassName%> <%=extraClasses.join(\' \')%>" name="<%=name%>" oncopy="return false; oncut="return false; onpaste="return false;" maxlength="<%=maxlength%>" value="<%-value%>" placeholder="<%-placeholder%>" <%=disabled ? "disabled" : ""%> <%=required ? "required" : ""%> />', ' <% if (helpMessage && helpMessage.length) { %>', ' <span class="<%=Backform.helpMessageClassName%>"><%=helpMessage%></span>', ' <% } %>', diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js index e82da8bec..a64897b20 100644 --- a/web/pgadmin/static/js/backgrid.pgadmin.js +++ b/web/pgadmin/static/js/backgrid.pgadmin.js @@ -698,6 +698,7 @@ define([ $('<input>', { tabIndex: 0, type: 'checkbox', + 'aria-label': gettext('data toggle'), }).prop('checked', rawValue).prop('disabled', !editable).attr('data-toggle', 'toggle') .attr('data-size', options.size).attr('data-on', options.onText).attr('data-off', options.offText) .attr('data-width', options.width).attr('data-height', options.height) diff --git a/web/pgadmin/tools/maintenance/static/js/maintenance.js b/web/pgadmin/tools/maintenance/static/js/maintenance.js index 6cebd3c07..4f1508233 100644 --- a/web/pgadmin/tools/maintenance/static/js/maintenance.js +++ b/web/pgadmin/tools/maintenance/static/js/maintenance.js @@ -6,7 +6,6 @@ // This software is released under the PostgreSQL Licence // ////////////////////////////////////////////////////////////// - define([ 'sources/gettext', 'sources/url_for', 'jquery', 'underscore', 'pgadmin.alertifyjs', 'sources/pgadmin', 'pgadmin.browser', 'backbone', @@ -277,6 +276,7 @@ define([ type: 'button', url: 'maintenance.html', label: gettext('Maintenance'), + 'aria-label': gettext('Object Help'), }, }, { text: '', @@ -417,7 +417,6 @@ define([ prepare: function() { // Main maintenance tool dialog container var $container = $('<div class=\'maintenance_dlg\'></div>'); - var t = pgBrowser.tree, i = t.selected(), d = i && i.length == 1 ? t.itemData(i) : undefined, diff --git a/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js b/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js index 396eab0fe..712d70cbc 100644 --- a/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js +++ b/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js @@ -38,6 +38,7 @@ export class RestoreDialogWrapper extends DialogWrapper { type: 'button', url: 'backup.html', label: gettext('Restore'), + 'aria-label': gettext('Object Help'), }, }, { text: '', ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [Accessibility] RM4608 Few issues in the dialogs. @ 2020-03-19 09:02 Akshay Joshi <[email protected]> parent: Pradip Parkale <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Akshay Joshi @ 2020-03-19 09:02 UTC (permalink / raw) To: Pradip Parkale <[email protected]>; +Cc: pgadmin-hackers Hi Pradip Can you please list down the things that you have fixed in this patch. On Thu, Mar 19, 2020 at 2:26 PM Pradip Parkale < [email protected]> wrote: > Hi Hackers, > > Please find the patch for accessibility errors in some of the dialogs. > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [Accessibility] RM4608 Few issues in the dialogs. @ 2020-03-19 09:18 Pradip Parkale <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Pradip Parkale @ 2020-03-19 09:18 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers Hi Akshay, Please find the things which I have fixed in this patch. Fixed some accessibility issues: 1) Aria-label additions at few missing places. 2) Label additions with 'sr-only' class where hidden labels required. 3) Converted label to span to solve accessibility error. I also incorporated the review comments given by Khushboo related to RM4237. It was related to DateTime picker control using the keyboard. On Thu, Mar 19, 2020 at 2:32 PM Akshay Joshi <[email protected]> wrote: > Hi Pradip > > Can you please list down the things that you have fixed in this patch. > > On Thu, Mar 19, 2020 at 2:26 PM Pradip Parkale < > [email protected]> wrote: > >> Hi Hackers, >> >> Please find the patch for accessibility errors in some of the dialogs. >> >> >> -- >> Thanks & Regards, >> Pradip Parkale >> QMG, EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [Accessibility] RM4608 Few issues in the dialogs. @ 2020-03-19 10:51 Akshay Joshi <[email protected]> parent: Pradip Parkale <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Akshay Joshi @ 2020-03-19 10:51 UTC (permalink / raw) To: Pradip Parkale <[email protected]>; +Cc: pgadmin-hackers Thanks, patch applied. On Thu, Mar 19, 2020 at 2:48 PM Pradip Parkale < [email protected]> wrote: > Hi Akshay, > Please find the things which I have fixed in this patch. > > Fixed some accessibility issues: > 1) Aria-label additions at few missing places. > 2) Label additions with 'sr-only' class where hidden labels required. > 3) Converted label to span to solve accessibility error. > > I also incorporated the review comments given by Khushboo related to > RM4237. It was related to DateTime picker control using the keyboard. > > On Thu, Mar 19, 2020 at 2:32 PM Akshay Joshi < > [email protected]> wrote: > >> Hi Pradip >> >> Can you please list down the things that you have fixed in this patch. >> >> On Thu, Mar 19, 2020 at 2:26 PM Pradip Parkale < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> Please find the patch for accessibility errors in some of the dialogs. >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> QMG, EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2020-03-19 10:51 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-03-19 08:56 [Accessibility] RM4608 Few issues in the dialogs. Pradip Parkale <[email protected]> 2020-03-19 09:02 ` Akshay Joshi <[email protected]> 2020-03-19 09:18 ` Pradip Parkale <[email protected]> 2020-03-19 10:51 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox