public inbox for [email protected]help / color / mirror / Atom feed
PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) 4+ messages / 2 participants [nested] [flat]
* PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) @ 2016-07-14 06:00 Murtuza Zabuawala <[email protected]> 2016-07-15 11:01 ` Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Murtuza Zabuawala @ 2016-07-14 06:00 UTC (permalink / raw) To: pgadmin-hackers Hi, PFA patch to fix the issue in timestamp datatype(s) displaying with time as 00:00 (RM#1437) The issue was with backgrid datetime cell which do not fully support ISO-8601 datetime format. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers Attachments: [application/octet-stream] RM_1437.patch (1.1K, 3-RM_1437.patch) download | inline diff: diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js index 965d56e..8b2d8dd 100644 --- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js +++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js @@ -1556,9 +1556,17 @@ define( case "numeric": col_cell = 'number'; break; + case "date": + case "reltime": + case "abstime": case "timestamp without time zone": case "timestamp with time zone": - col_cell = 'datetime'; + case "time with time zone": + case "time without time zone": + case "interval": + col_cell = Backgrid.DatetimeCell.extend({ + formatter: Backgrid.StringFormatter, + }); break; case "json": case "json[]": ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) 2016-07-14 06:00 PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Murtuza Zabuawala <[email protected]> @ 2016-07-15 11:01 ` Dave Page <[email protected]> 2016-07-18 06:34 ` Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Murtuza Zabuawala <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Dave Page @ 2016-07-15 11:01 UTC (permalink / raw) To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers Hi On Thu, Jul 14, 2016 at 7:00 AM, Murtuza Zabuawala <[email protected]> wrote: > Hi, > > PFA patch to fix the issue in timestamp datatype(s) displaying with time as > 00:00 > (RM#1437) > > The issue was with backgrid datetime cell which do not fully support > ISO-8601 datetime format. Thanks - this worked, except for the 'interval' type, I've committed the patch without that change; please submit another fixing that remaining issue. e.g. select '1 month'::interval displays: 00:00:00 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) 2016-07-14 06:00 PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Murtuza Zabuawala <[email protected]> 2016-07-15 11:01 ` Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Dave Page <[email protected]> @ 2016-07-18 06:34 ` Murtuza Zabuawala <[email protected]> 2016-07-18 08:42 ` Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Murtuza Zabuawala @ 2016-07-18 06:34 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Hi Dave, Please find patch to fix the issue for interval type casting. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 15, 2016 at 4:31 PM, Dave Page <[email protected]> wrote: > Hi > > On Thu, Jul 14, 2016 at 7:00 AM, Murtuza Zabuawala > <[email protected]> wrote: > > Hi, > > > > PFA patch to fix the issue in timestamp datatype(s) displaying with time > as > > 00:00 > > (RM#1437) > > > > The issue was with backgrid datetime cell which do not fully support > > ISO-8601 datetime format. > > Thanks - this worked, except for the 'interval' type, I've committed > the patch without that change; please submit another fixing that > remaining issue. > > e.g. select '1 month'::interval > > displays: 00:00:00 > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers Attachments: [application/octet-stream] add_support_for_interval.patch (601B, 3-add_support_for_interval.patch) download | inline diff: diff --git a/web/pgadmin/utils/driver/psycopg2/__init__.py b/web/pgadmin/utils/driver/psycopg2/__init__.py index 751dd0c..ec0a8fc 100644 --- a/web/pgadmin/utils/driver/psycopg2/__init__.py +++ b/web/pgadmin/utils/driver/psycopg2/__init__.py @@ -53,6 +53,11 @@ psycopg2.extensions.register_type( psycopg2.extensions.new_type((701,), 'NaN_TEXT', psycopg2.STRING) ) +# This registers a type caster for datatype 'interval'. +psycopg2.extensions.register_type( + psycopg2.extensions.new_type((1186,), 'INTERVAL_TEXT', psycopg2.STRING) +) + def register_date_typecasters(connection): """ ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) 2016-07-14 06:00 PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Murtuza Zabuawala <[email protected]> 2016-07-15 11:01 ` Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Dave Page <[email protected]> 2016-07-18 06:34 ` Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Murtuza Zabuawala <[email protected]> @ 2016-07-18 08:42 ` Dave Page <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Dave Page @ 2016-07-18 08:42 UTC (permalink / raw) To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers Thanks - applied. On Mon, Jul 18, 2016 at 7:34 AM, Murtuza Zabuawala <[email protected]> wrote: > Hi Dave, > > Please find patch to fix the issue for interval type casting. > > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Fri, Jul 15, 2016 at 4:31 PM, Dave Page <[email protected]> wrote: >> >> Hi >> >> On Thu, Jul 14, 2016 at 7:00 AM, Murtuza Zabuawala >> <[email protected]> wrote: >> > Hi, >> > >> > PFA patch to fix the issue in timestamp datatype(s) displaying with time >> > as >> > 00:00 >> > (RM#1437) >> > >> > The issue was with backgrid datetime cell which do not fully support >> > ISO-8601 datetime format. >> >> Thanks - this worked, except for the 'interval' type, I've committed >> the patch without that change; please submit another fixing that >> remaining issue. >> >> e.g. select '1 month'::interval >> >> displays: 00:00:00 >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2016-07-18 08:42 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2016-07-14 06:00 PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) Murtuza Zabuawala <[email protected]> 2016-07-15 11:01 ` Dave Page <[email protected]> 2016-07-18 06:34 ` Murtuza Zabuawala <[email protected]> 2016-07-18 08:42 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox