Re: [pgAdmin4][RM#3154] Update modules to latest version

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version
Date: Fri, 6 Apr 2018 13:22:15 +0530
Message-ID: <CAKKotZQ91y1j8PZ4oZ9tHe0LYb6xS8B11tkbbf-KiHCKUEM6rg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQsx8MQ1Di+bm9t5aeWXU-kMeYQKi-rrfntjqF+7mNR+g@mail.gmail.com>
References: <CAKKotZRD_epwD7wQE0pXPJJx_6di=xpsCzNEXiTm9LqYCSWFjQ@mail.gmail.com>
	<CA+OCxoxKZ=LeY+GWW0RMz-Fcd9KrR0jm1FWQoYexshaOe2Uiyw@mail.gmail.com>
	<CAKKotZQRQpDdn2KbqcUFZ_UaMnruAOxxt7dzasn6C-ShODANvQ@mail.gmail.com>
	<CAKKotZTEHy_=8v6rP0xUhks_pDwiAH2iB43BHegqXDVbySgiAg@mail.gmail.com>
	<CAKKotZSXA3H5UuDLKA1E0X5+VShZT7cHHPir1yfGDQ7Q0sV6Jg@mail.gmail.com>
	<CAE+jjakAoNAhUbH1zJ-noWOQJKmXu0EiiaMHq7+5amcPUNCT8A@mail.gmail.com>
	<CAKKotZS+nHFp0EzocJJjDT5asTaJs3QDAzV5OYixAF5JM9+Y1A@mail.gmail.com>
	<CA+OCxoxmbRemLkLgcDPQLid8x1RHajtnC_octnGHVyqaD_9URw@mail.gmail.com>
	<CAKKotZQsx8MQ1Di+bm9t5aeWXU-kMeYQKi-rrfntjqF+7mNR+g@mail.gmail.com>

Hi Dave,

I checked and found that the issue was in wcDocker which was causing
problem while opening query tool,
I have logged an issue on github:
https://github.com/WebCabin/wcDocker/issues/124

Query tool, Debugger etc are working properly when open in new Browser Tab
and not in Panel.

I'm also able to fix the issue which I was facing while running Jasmine
test by correctting the path for *jquery.event.drag* library from
jquery.event.drag-2.2 to jquery.event.drag-2.3.0.

Let's wait for author's reply on the issue.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Apr 4, 2018 at 3:20 PM, Murtuza Zabuawala <
[email protected]> wrote:

> On Wed, Apr 4, 2018 at 3:19 PM, Dave Page <[email protected]> wrote:
>
>>
>>
>> On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi Joao,
>>>
>>> Yes it bundles latest version but I doubt that is not using it, If we
>>> upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid.
>>> I have tried that and I started getting jQuery related errors when
>>> trying to run query tool or when running jasmine tests.
>>>
>>
>> Can you spend some time trying to figure it out please? We need to get on
>> to 3.x as older versions are no longer receiving updates which could pose a
>> security risk.
>>
> Sure Dave.
>
>
>>
>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira <
>>> [email protected]> wrote:
>>>
>>>> Hi Murtuza,
>>>>
>>>> The patches look good and they pass all tests in CI.
>>>> One think that we realized was the SlickGrid as a npm package now:
>>>> https://www.npmjs.com/package/slickgrid
>>>> Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully
>>>> supported or not......
>>>>
>>>> Thanks
>>>> Victoria & Joao
>>>>
>>>> On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> Reverted back jQuery version to 1.x because of SlickGrid dependancy.
>>>>> Please find updated patch.
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Please hold on my previous patch.
>>>>>>
>>>>>> We can't use latest jQuery version as SlickGrid has dependancy on
>>>>>> older version.
>>>>>> I'll send updated patch again.
>>>>>>
>>>>>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> Please find updated patches, there are two patches attached one is
>>>>>>> for the story and another is for changes required as per new modules.
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> PFA patch to update the modules to latest version.
>>>>>>>>>
>>>>>>>>>
>>>>>>>> - Why isn't jQuery updated to 3.3.1?
>>>>>>>>
>>>>>>> Done
>>>>>>>
>>>>>>>
>>>>>>>> 
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to
>>>>>>>> psycopg2 and pycrypto etc?
>>>>>>>>
>>>>>>> Done
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> We are not able to update some of the modules to latest version
>>>>>>>>> due to dependancy on other modules, For example
>>>>>>>>> - Python: Flask-Security has dependancy on flask-babelex which
>>>>>>>>> causes conflict with flask_babel
>>>>>>>>>
>>>>>>>>
>>>>>>>> Hmm, flask-babelex might be a better option anyway; in particular,
>>>>>>>> it avoids loading catalogs with every request which seems desirable given
>>>>>>>> the size of ours. On the other hand, it hasn't been updated so recently.
>>>>>>>>
>>>>>>> I have removed flask-babel and used flask_babelex instead.
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch &
>>>>>>>>> Bootstrap Datetime picker has dependancy on Bootstrap3.
>>>>>>>>>
>>>>>>>>
>>>>>>>> OK.
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>> Twitter: @pgsnake
>>>>>>>>
>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version
  In-Reply-To: <CAKKotZQ91y1j8PZ4oZ9tHe0LYb6xS8B11tkbbf-KiHCKUEM6rg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox