public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Chethana Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM 5271] To change the switch control colors
Date: Thu, 19 Mar 2020 12:10:17 +0530
Message-ID: <CAKKotZQGVtAS2_ZKsEp2ReMAZv5a++LyxDE26BWoZm98hd7rvg@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_=k=auV3dPTx1SgxbjyA8A3Z+Wfnm-S6x=ekK17Wg8LmQ@mail.gmail.com>
References: <CAKKotZQezDN2uY5Xu-iuV2eOqN=KXU0=MPmkJpnYGvRUnBF-0w@mail.gmail.com>
<CAH4-4WsyPJ++u9DrF08mH5R_NsuW9htW7WucxuZxkG=-djVe8w@mail.gmail.com>
<CAKKotZRymZtuez5iThP+NKWBrT0PDOPUsh-mn3wsAkzO5jstBA@mail.gmail.com>
<CAH4-4WvHttwdvs+KYcRhpTRGYFTRxz=yQZ5rGjFHjo2q+jg=tw@mail.gmail.com>
<CAM9w-_=k=auV3dPTx1SgxbjyA8A3Z+Wfnm-S6x=ekK17Wg8LmQ@mail.gmail.com>
Hello,
PFA updated patch with new colors provided by Chethana, As discussed we
will be using the same primary success color in both theme so we don't have
add new variable.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Murtuza/Chethana,
>
> Irrespective of what color you suggest, there is no need to add new
> variables for switch buttons. It should use success for on and ternary for
> off.
> Having a separate green color for each and every control is absurd. If the
> green changes, it should change for all.
>
> On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar <
> [email protected]> wrote:
>
>> Let us discuss on a call for better clarity and the conclusion part we
>> can put it on mail.
>>
>> ---
>> Chethana kumar
>>
>> On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi Chethana,
>>>
>>> No it is not, As per current dark theme implementation we have used
>>> primary color '#1a522b' for switch but the color you suggested is '#43A047'
>>> for both theme.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>>
>>> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <
>>> [email protected]> wrote:
>>>
>>>> Hi Murtuza,
>>>>
>>>> The changes are already incorporated so no worries :)
>>>>
>>>> Thanks,
>>>>
>>>> ---
>>>> Chethana kumar
>>>>
>>>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <
>>>> [email protected]> wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> As per discussion with Chethana, We need to make switch box color
>>>>> change for light and dark theme, Color details provided by Chethana is
>>>>> updated on ticket.
>>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>
>>>> --
>>>> Chethana Kumar
>>>> Principal UI/UX Designer
>>>> EnterpriseDB Corporation
>>>>
>>>> The Postgres Database Company
>>>>
>>>> P: +91 86981 57146
>>>> www.enterprisedb.com
>>>>
>>>
>>
>> --
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146
>> www.enterprisedb.com
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
Attachments:
[application/octet-stream] RM_5271_v1.diff (1.2K, 3-RM_5271_v1.diff)
download | inline diff:
diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss
index 14db912f0..9fe30cb9e 100644
--- a/web/pgadmin/static/scss/resources/_default.variables.scss
+++ b/web/pgadmin/static/scss/resources/_default.variables.scss
@@ -25,7 +25,7 @@ $color-danger-lighter: #FAECEC !default;
$color-success: #43a047 !default;
$color-success-fg: $black !default;
-$color-success-light: #DDF1DE !default;
+$color-success-light: #D9ECDA !default;
$color-warning: #eea236 !default;
$color-warning-fg: $black !default;
diff --git a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
index e82640eba..872fe6f62 100644
--- a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
+++ b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
@@ -17,9 +17,9 @@ $color-danger-fg: $white;
$color-danger-light: #914649;
$color-danger-lighter: #212121;
-$color-success: #1a522b;
+$color-success: #43a047;
$color-success-fg: $black;
-$color-success-light: #5a7863;
+$color-success-light: #2B472C;
$color-warning: #eea236;
$color-warning-fg: $black;
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][RM 5271] To change the switch control colors
In-Reply-To: <CAKKotZQGVtAS2_ZKsEp2ReMAZv5a++LyxDE26BWoZm98hd7rvg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox